Skip to content

Commit 8c537f8

Browse files
committed
First step to implementing new form security purge().
git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@5621 f5dc347c-c33d-0410-90a0-b07cc1902cb9
1 parent cbffce7 commit 8c537f8

32 files changed

+63
-5
lines changed

manage_config_email_set.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@
151151
}
152152
}
153153

154-
154+
form_security_purge('manage_config_email_set');
155155
?>
156156

157157
<br />

manage_config_revert.php

+2
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@
5656
foreach ( $t_revert_vars as $t_revert ) {
5757
config_delete( $t_revert, null , $f_project_id );
5858
}
59+
60+
form_security_purge('manage_config_revert');
5961
}
6062

6163
$t_redirect_url = $f_return;

manage_custom_field_create.php

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
$t_redirect_url = 'manage_custom_field_page.php';
4747
}
4848

49+
form_security_purge('manage_custom_field_create');
50+
4951
html_page_top1();
5052
html_meta_redirect( $t_redirect_url );
5153
html_page_top2();

manage_custom_field_delete.php

+2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@
5353

5454
custom_field_destroy( $f_field_id );
5555

56+
form_security_purge('manage_custom_field_delete');
57+
5658
html_page_top1();
5759
html_meta_redirect( $f_return );
5860
html_page_top2();

manage_custom_field_proj_add.php

+2
Original file line numberDiff line numberDiff line change
@@ -46,5 +46,7 @@
4646
}
4747
}
4848

49+
form_security_purge('manage_custom_field_proj_add');
50+
4951
print_header_redirect( 'manage_custom_field_edit_page.php?field_id=' . $f_field_id );
5052
?>

manage_custom_field_update.php

+2
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@
6060

6161
custom_field_update( $f_field_id, $t_values );
6262

63+
form_security_purge('manage_custom_field_update');
64+
6365
html_page_top1();
6466

6567
html_meta_redirect( $f_return );

manage_proj_cat_add.php

+2
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@
6464
}
6565
}
6666

67+
form_security_purge( 'manage_proj_cat_add' );
68+
6769
if ( $f_project_id == ALL_PROJECTS ) {
6870
$t_redirect_url = 'manage_proj_page.php';
6971
} else {

manage_proj_cat_copy.php

+2
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@
6161
}
6262
}
6363

64+
form_security_purge( 'manage_proj_cat_copy' );
65+
6466
if ( $f_project_id == ALL_PROJECTS ) {
6567
$t_redirect_url = 'manage_proj_page.php';
6668
} else {

manage_proj_cat_delete.php

+2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@
5353
form_security_validate( 'manage_proj_cat_delete' );
5454
category_remove( $f_category_id );
5555

56+
form_security_purge( 'manage_proj_cat_delete' );
57+
5658
if ( $f_project_id == ALL_PROJECTS ) {
5759
$t_redirect_url = 'manage_proj_page.php';
5860
} else {

manage_proj_cat_update.php

+2
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555

5656
category_update( $f_category_id, $f_name, $f_assigned_to );
5757

58+
form_security_purge( 'manage_proj_cat_update' );
59+
5860
if ( $f_project_id == ALL_PROJECTS ) {
5961
$t_redirect_url = 'manage_proj_page.php';
6062
} else {

manage_proj_create.php

+2
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@
6161
project_hierarchy_add( $t_project_id, $f_parent_id, $f_inherit_parent );
6262
}
6363

64+
form_security_purge( 'manage_proj_create' );
65+
6466
$t_redirect_url = 'manage_proj_page.php';
6567

6668
html_page_top1();

manage_proj_custom_field_add_existing.php

+2
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444

4545
custom_field_link( $f_field_id, $f_project_id );
4646

47+
form_security_purge( 'manage_proj_custom_field_add_existing' );
48+
4749
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' . $f_project_id;
4850

4951
html_page_top1();

manage_proj_custom_field_copy.php

+2
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,7 @@
4949

5050
project_copy_custom_fields( $t_dst_project_id, $t_src_project_id );
5151

52+
form_security_purge( 'manage_proj_custom_field_copy' );
53+
5254
print_header_redirect( 'manage_proj_edit_page.php?project_id=' . $f_project_id );
5355
?>

manage_proj_custom_field_remove.php

+2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@
5858
form_security_validate( 'manage_proj_custom_field_remove' );
5959
custom_field_unlink( $f_field_id, $f_project_id );
6060

61+
form_security_purge( 'manage_proj_custom_field_remove' );
62+
6163
html_page_top1();
6264
html_meta_redirect( $t_redirect_url );
6365
html_page_top2();

manage_proj_custom_field_update.php

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545

4646
custom_field_set_sequence( $f_field_id, $f_project_id, $f_sequence );
4747

48+
form_security_purge( 'manage_proj_custom_field_update' );
49+
4850
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' . $f_project_id;
4951
?>
5052
<?php html_page_top1() ?>

manage_proj_delete.php

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040

4141
form_security_validate( 'manage_proj_delete' );
4242
project_delete( $f_project_id );
43+
form_security_purge( 'manage_proj_delete' );
4344

4445
# Don't leave the current project set to a deleted project -
4546
# set it to All Projects

manage_proj_subproj_add.php

+2
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444
}
4545
project_hierarchy_add( $f_subproject_id, $f_project_id );
4646

47+
form_security_purge( 'manage_proj_subproj_add' );
48+
4749
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' . $f_project_id;
4850

4951
html_page_top1();

manage_proj_subproj_delete.php

+2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
access_ensure_project_level( config_get( 'manage_project_threshold' ), $f_project_id );
3838

3939
project_hierarchy_remove( $f_subproject_id, $f_project_id );
40+
41+
form_security_purge( 'manage_proj_subproj_delete' );
4042

4143
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' . $f_project_id;
4244

manage_proj_update.php

+2
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,7 @@
4242

4343
project_update( $f_project_id, $f_name, $f_description, $f_status, $f_view_state, $f_file_path, $f_enabled, $f_inherit_global );
4444

45+
form_security_purge( 'manage_proj_update' );
46+
4547
print_header_redirect( 'manage_proj_page.php' );
4648
?>

manage_proj_update_children.php

+2
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,6 @@
4444
project_hierarchy_update( $t_subproject_id, $f_project_id, $f_inherit_child );
4545
}
4646

47+
form_security_purge( 'manage_proj_update_children' );
48+
4749
print_successful_redirect( 'manage_proj_edit_page.php?project_id=' . $f_project_id );

manage_proj_user_add.php

+2
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,7 @@
4444
project_add_user( $f_project_id, $t_user_id, $f_access_level );
4545
}
4646

47+
form_security_purge( 'manage_proj_user_add' );
48+
4749
print_header_redirect( 'manage_proj_edit_page.php?project_id=' . $f_project_id );
4850
?>

manage_proj_user_copy.php

+2
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,7 @@
5353

5454
project_copy_users( $t_dst_project_id, $t_src_project_id );
5555

56+
form_security_purge( 'manage_proj_user_copy' );
57+
5658
print_header_redirect( 'manage_proj_edit_page.php?project_id=' . $f_project_id );
5759
?>

manage_proj_user_remove.php

+3-4
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
require_once( 'core.php' );
2828

2929
auth_reauthenticate();
30+
form_security_validate( 'manage_proj_user_remove' );
3031

3132
$f_project_id = gpc_get_int( 'project_id' );
3233
$f_user_id = gpc_get_int( 'user_id', 0 );
@@ -41,8 +42,6 @@
4142
# Confirm with the user
4243
helper_ensure_confirmed( lang_get( 'remove_all_users_sure_msg' ), lang_get( 'remove_all_users_button' ) );
4344

44-
form_security_validate( 'manage_proj_user_remove' );
45-
4645
project_remove_all_users( $f_project_id );
4746
}
4847
else {
@@ -52,11 +51,11 @@
5251
'<br/>' . lang_get( 'username' ) . ': ' . $t_user['username'],
5352
lang_get( 'remove_user_button' ) );
5453

55-
form_security_validate( 'manage_proj_user_remove' );
56-
5754
project_remove_user( $f_project_id, $f_user_id );
5855
}
5956

57+
form_security_purge( 'manage_proj_user_remove' );
58+
6059
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' . $f_project_id;
6160

6261
html_page_top1();

manage_proj_ver_add.php

+2
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@
6969
}
7070
}
7171

72+
form_security_purge( 'manage_proj_ver_add' );
73+
7274
if ( true == $f_add_and_edit ) {
7375
$t_version_id = version_get_id( $t_version, $f_project_id );
7476
$t_redirect_url = 'manage_proj_ver_edit_page.php?version_id='.$t_version_id;

manage_proj_ver_copy.php

+2
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,7 @@
6262
}
6363
}
6464

65+
form_security_purge( 'manage_proj_ver_copy' );
66+
6567
print_header_redirect( 'manage_proj_edit_page.php?project_id=' . $f_project_id );
6668
?>

manage_proj_ver_delete.php

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646

4747
form_security_validate( 'manage_proj_ver_delete' );
4848
version_remove( $f_version_id );
49+
form_security_purge( 'manage_proj_ver_delete' );
4950

5051
html_page_top1();
5152
html_meta_redirect( $t_redirect_url );

manage_proj_ver_update.php

+2
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@
5959

6060
version_update( $t_version );
6161

62+
form_security_purge( 'manage_proj_ver_update' );
63+
6264
$t_redirect_url = 'manage_proj_edit_page.php?project_id=' . $t_version->project_id;
6365
?>
6466
<?php

manage_user_create.php

+2
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@
8383

8484
$t_cookie = user_create( $f_username, $f_password, $f_email, $f_access_level, $f_protected, $f_enabled, $t_realname );
8585

86+
form_security_purge( 'manage_user_create' );
87+
8688
if ( $t_cookie === false ) {
8789
$t_redirect_url = 'manage_user_page.php';
8890
} else {

manage_user_delete.php

+2
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242

4343
user_delete( $f_user_id );
4444

45+
form_security_purge('manage_user_delete');
46+
4547
$t_redirect_url = 'manage_user_page.php';
4648

4749
html_page_top1();

manage_user_proj_add.php

+2
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,7 @@
4141
}
4242
}
4343

44+
form_security_purge('manage_user_proj_add');
45+
4446
print_header_redirect( 'manage_user_edit_page.php?user_id=' . $f_user_id );
4547
?>

manage_user_reset.php

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
$t_result = user_reset_password( $f_user_id );
4040
$t_redirect_url = 'manage_user_page.php';
4141

42+
form_security_purge('manage_user_reset');
43+
4244
html_page_top1();
4345
if ( $t_result ) {
4446
html_meta_redirect( $t_redirect_url );

manage_user_update.php

+3
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,9 @@
114114

115115
$result = db_query_bound( $query, $query_params );
116116
$t_redirect_url = 'manage_user_edit_page.php?user_id=' . $c_user_id;
117+
118+
form_security_purge('manage_user_update');
119+
117120
?>
118121
<?php html_page_top1() ?>
119122
<?php

0 commit comments

Comments
 (0)