Thanks for taking the time to help make harp better. Here are some guidlines that will highly increase the chances of your fix or feature request from being accepted.
If you find a bug you would like fixed. Open up a ticket with a detailed description of the bug and the expected behaviour. If you would like to fix the problem yourself please do the following steps.
- Fork it.
- Create a branch (
git checkout -b fix-for-that-thing) - Commit a failing test (
git commit -am "adds a failing test to demonstrate that thing") - Commit a fix that makes the test pass (
git commit -am "fixes that thing") - Push to the branch (
git push origin fix-for-that-thing) - Open a Pull Request
Please keep your branch up to date by rebasing upstream changes from master.
If you wish to add new functionality to harp, please provide @sintaxi and @kennethormandy a harp application that demonstrates deficiency in current design or desired additional behaviour. Its best if you explaing the problem you are trying to solve, not just the solution you want. You may also submit a pull request with the steps above.
Copyright © 2012–2014 Chloi Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.