Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

Explore possibility of time-based tests for trappy #257

Open
joelagnel opened this issue Jun 27, 2017 · 0 comments
Open

Explore possibility of time-based tests for trappy #257

joelagnel opened this issue Jun 27, 2017 · 0 comments

Comments

@joelagnel
Copy link

Recently lot of speed up related patches have posted. It would be good to be able to test and make sure these improvements aren't regressed in the future. One concern is that its hardware dependent and is hard to measure. This issue is created to discuss this.
I think we can still come up with a worst-case upper bound experimentally and set that as the expectation. If we are threading trappy in the future, then we can perhaps limit the number of threads so that the number of cores that the test is run on doesn't change or artificially make a failure result as passed (as a false-positive). (CC @derkling)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant