Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support unfinalized block with dev_newBlock #825

Open
shunjizhan opened this issue Sep 27, 2024 · 1 comment
Open

support unfinalized block with dev_newBlock #825

shunjizhan opened this issue Sep 27, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@shunjizhan
Copy link
Contributor

add a param to dev_newBlock to specify if the new blocks should be finalized, similar to provider.api.rpc.engine.createBlock. This will be helpful for testing finalization related behaviors.

@xlc
Copy link
Member

xlc commented Sep 27, 2024

We need a mode to handle block finalization strategy.

Add new config finalize-block-mode that can be:

  • 'latest': (the default behaviour that always mark latest block to be finalized
  • 'manual': never automatically finalize block

and add new RPC dev_setFinalizedHead to control which block should be finalized

on manual mode, dev_newBlock can have a finalize: bool argument to specify if this block should be mark as finalized

@xlc xlc added the good first issue Good for newcomers label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants