Fix hrefs that had single quotes #10
Conversation
|
This fix looks good to me. @ActionRetro are you able to merge this and deploy to frogfind.com? |
|
Let's get this merged! |
|
@lazd This branch has a few small conflicts after #21 got merged, but that's only because this branch includes some fixes in files that now no longer exist (left-over files of the 68k.news project that were in here too). If you were to pull in the latest from |
|
Thanks @jibsaramnim, it's up to date now! |
There was a problem hiding this comment.
@ActionRetro For what it's worth, I took a look through this and it's looking great. A nice small PR that you might be able to squeeze in for the next release you might be planning on? Thank you so much for all that you do! 🙏
This PR fixes instances where attribute values were quoted with single quotes. Netscape 1.12 doesn't like this, and this was resulting in all links to be broken.
I imagine this originally happened because of PHP's nice variable interpolation feature when double quotes are used (i.e.
"Hi my name is $name"), but most instances used the string concatenation operator (.), so I just kept them as-is instead of trying to get fancy and escape chars.I couldn't test this as I don't have a PHP environment running locally, but it should work!
Fixes #5