Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joinmarket integration #10

Open
AdamISZ opened this issue Apr 26, 2017 · 0 comments
Open

Joinmarket integration #10

AdamISZ opened this issue Apr 26, 2017 · 0 comments

Comments

@AdamISZ
Copy link
Owner

AdamISZ commented Apr 26, 2017

See JoinMarket-Org/joinmarket#335 for ideas about CoinSwap on Joinmarket.

For now this repo is being deliberately done in the simplest way I can imagine, with an HTTP JSON-RPC interface.

There is nothing difficult about having the counterparties interact over the existing message channel code in jmclient, except for the fact that it needs running the underlying jmdaemon code either in-process or separately.

On that topic, IRC is not a particularly bad messaging interface for this, and we already have very well tested/functioning code including Tor/SOCKS. One change that may well be needed in-line with other discussions is, create the possibility to persist nicks(IDs) on the message channel; this has been considered undesirable for JM but may make sense here (it's easy to do).

The fact that the code currently uses joinmarket's wallet code (and is therefore compatible with it) is relevant; one point that's simple is: JM may make one sensible source for server utxos. See #11

At the more application level, the question of whether a market based fees and offer/fill approach makes sense/interacts with other issues mentioned here, like #8 and the whole discussion of persistent ID, client-server and DOS mentioned here and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant