Remove http.DefaultClient altogether

Use a global http.Client from cleanhttp for all http requests, unless
specifically overridden.

Author: jbardin

get.go

@@ -51,10 +51,12 @@ var Getters map[string]Getter
 // syntax is schema::url, example: git::https://foo.com
 var forcedRegexp = regexp.MustCompile(`^([A-Za-z0-9]+)::(.+)$`)
 
+// httpClient is the default client to be used by HttpGetters.
+var httpClient = cleanhttp.DefaultClient()
+
 func init() {
 	httpGetter := &HttpGetter{
-		Netrc:  true,
-		Client: cleanhttp.DefaultClient(),
+		Netrc: true,
 	}
 
 	Getters = map[string]Getter{

get_http.go

@@ -38,7 +38,7 @@ type HttpGetter struct {
 	Netrc bool
 
 	// Client is the http.Client to use for Get requests.
-	// This defaults to http.DefaultClient if left unset.
+	// This defaults to a cleanhttp.DefaultClient if left unset.
 	Client *http.Client
 }
 
@@ -62,7 +62,7 @@ func (g *HttpGetter) Get(dst string, u *url.URL) error {
 	}
 
 	if g.Client == nil {
-		g.Client = http.DefaultClient
+		g.Client = httpClient
 	}
 
 	// Add terraform-get to the parameter.
@@ -115,7 +115,7 @@ func (g *HttpGetter) GetFile(dst string, u *url.URL) error {
 	}
 
 	if g.Client == nil {
-		g.Client = http.DefaultClient
+		g.Client = httpClient
 	}
 
 	resp, err := g.Client.Get(u.String())