Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal methods marked for logging do not get called #3

Open
cas8180 opened this issue Dec 22, 2015 · 3 comments
Open

Internal methods marked for logging do not get called #3

cas8180 opened this issue Dec 22, 2015 · 3 comments

Comments

@cas8180
Copy link

cas8180 commented Dec 22, 2015

It would appear that to invoke logging for a method even if its decorated with a logging aspect attribute has to be called externally via the instance of the dynamic object reference. This would be a huge limitation as it appears that internal method call that take place within the class itself never get their respective aspect invoked and thus never get logged as part of a call start. Or whatever other functionality you might introduce other than logging. This would mean that in order to use this framework one would have to change their architecture so that every single method gets called in reference to the dynamic instance of an object and can not call methods internally if they are expecting aspect based behavior to execute.

@AntyaDev
Copy link
Owner

PR is welcome)

@cas8180
Copy link
Author

cas8180 commented Dec 25, 2015

Wtf?

@AntyaDev
Copy link
Owner

@cas8180 I meant that your pull request is welcome)
But I am not sure how to achieve that behavior for internal methods since the "AOP magic" can work only with "dynamic". I agree this is the big limitation. But I think that AOP can be achieved simpler with just composition of functions without any AOP framework. (func1 >> func2 >> func3Logging >> func4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants