From 8ae73502d47f4e1e4980f08542369a3b4dba49ae Mon Sep 17 00:00:00 2001 From: Filippos Vasilakis Date: Mon, 2 Dec 2019 21:13:27 +0100 Subject: [PATCH] small fixes on key transformation, bump to 0.2.1 --- lib/simple_ams/adapters/jsonapi.rb | 12 ++++++------ lib/simple_ams/document.rb | 5 +---- lib/simple_ams/version.rb | 2 +- simple_ams.gemspec | 2 +- 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/lib/simple_ams/adapters/jsonapi.rb b/lib/simple_ams/adapters/jsonapi.rb index 08fcc16..d797048 100644 --- a/lib/simple_ams/adapters/jsonapi.rb +++ b/lib/simple_ams/adapters/jsonapi.rb @@ -47,12 +47,12 @@ def fields def transform_key(key) case options[:key_transform] - #when :camel - #when :camel_lower - when :dash + when :camel + key.to_s.split('_').map(&capitalize).join + when :kebab key.to_s.gsub('_','-') - when :underscore - key.to_s.gsub('-', '_') + when :snake + key else key end @@ -83,7 +83,7 @@ def embedded_relation_data_for(relation) return {} if relation.embedded.generics[:skip_data]&.value if relation.folder? - value = relation.documents.map{|doc| + value = relation.each.map{|doc| { doc.primary_id.name => doc.primary_id.value.to_s, type: doc.type.name diff --git a/lib/simple_ams/document.rb b/lib/simple_ams/document.rb index ef44aca..502ac6d 100644 --- a/lib/simple_ams/document.rb +++ b/lib/simple_ams/document.rb @@ -103,10 +103,7 @@ def each(&block) #do we really need this method ? def documents - @members.map do |resource| - #need optimization here! - SimpleAMS::Document.new(options_for(resource)) - end + each.map end def resource_options diff --git a/lib/simple_ams/version.rb b/lib/simple_ams/version.rb index bc4b099..fa7bb09 100644 --- a/lib/simple_ams/version.rb +++ b/lib/simple_ams/version.rb @@ -1,3 +1,3 @@ module SimpleAMS - VERSION = "0.2.0" + VERSION = "0.2.1" end diff --git a/simple_ams.gemspec b/simple_ams.gemspec index 0e79d2d..22ea854 100644 --- a/simple_ams.gemspec +++ b/simple_ams.gemspec @@ -20,7 +20,7 @@ Gem::Specification.new do |spec| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.15" + spec.add_development_dependency "bundler", "~> 2.0.2" spec.add_development_dependency "rake", "~> 10.0" spec.add_development_dependency "rspec", "~> 3.0" spec.add_development_dependency "faker", "~> 1.8.5"