Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce thread usage of Chrome event-listening #275

Open
speezepearson opened this issue Jul 31, 2019 · 0 comments
Open

Reduce thread usage of Chrome event-listening #275

speezepearson opened this issue Jul 31, 2019 · 0 comments
Assignees
@speezepearson
Labels
enhancement

Comments

@speezepearson
Copy link
Contributor

speezepearson commented Jul 31, 2019 •
edited
Loading

(Context this comment)
There's a completableFuture.get() call floating around, and it doesn't really matter because it shouldn't take long and doesn't block any important thread, but it's still discomfiting. It would be nice to get rid of it, which probably requires changing the signature of DevToolsService.nowOrOnEvent from taking a Supplier<Boolean> to taking a Supplier<CompletableFuture<Boolean>> or something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@speezepearson speezepearson

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@speezepearson