Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nettosphere does not fully shutdown in unit tests #145

Closed
supertick opened this issue Mar 19, 2019 · 1 comment
Closed

Nettosphere does not fully shutdown in unit tests #145

supertick opened this issue Mar 19, 2019 · 1 comment
Milestone
3.0.13

Comments

@supertick
Copy link
Contributor

supertick commented Mar 19, 2019 •
edited
Loading

Hello Again,
Nettosphere is still failing my unit tests because the threads are not fully shutdown. I believe since its an asynchronous shutdown, unless synch() is specified, allows the controlling thread doing the testing to be removed before shutdown is completed.

I've tested with the synch() and it looks good (#143)

I did not know what your design intention is, but a blocking stop() until the server is fully stopped might be desirable.

Regards.
@supertick
Copy link
Contributor Author

Thanks for merging (#143)
excited to see lucky 3.0.13 in maven central !

Cheers !

@jfarcand jfarcand added this to the 3.0.13 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.13
Development

No branches or pull requests
2 participants
@jfarcand @supertick