Top Posts & Pages widget: applies filter post type choice filter after calculating total posts to display

[macmanx2]

The updated Top Posts & Pages widget from Jetpack 3.6 is applying the types choice after the total is collected, which in most cases results in a mismatch with the desired total. This is hard for me to explain with words, so how about an example? :)

http://macmanx.com/ has 1,276 Posts, with stats going back to the day Jetpack was first released, yet when I set my Top Posts & Pages widget to display my top 10 posts, it only displays 6. If I set it to display my top 10 posts and pages, it displays 10, and 4 of those are pages.

In the above example, rather than fetching my top 10 posts, the widget fetches my top 10 posts and pages, then filters out the 6 posts from that.

[jeherve]

Also reported here:
https://wordpress.org/support/topic/top-posts-and-pages-widget-displays-too-many-entries-when-filtered-by-page-types?replies=1&view=all

[kraftbj]

One suggestion for this is to pull a higher number (whatever reasonable... 20, 50, etc), then filter them locally to return the specific number of posts or pages.

[kraftbj]

Also noting that this would also be resolved by #2196, though my earlier suggestion would work depending on the timeline for the rewrite.

[mediageni]

Top Posts & Pages (JetPack) stopped working, I had 10 posts displaying yesterday, now it's only showing one. What can be wrong?

[jeherve]

@scriptgeni Can you please use Jetpack's Debugger module to send us some more information about your site?

1. Go to the Jetpack page in your dashboard.
2. Click on the Debug link appearing at the bottom of the page.
3. Click the link that says "click here to contact Jetpack support."
4. Fill in the description box and your name and email address.
5. Click the "Contact Support" button.

Thanks!

[atrus1701]

I recently fixed the issue #2196 mentioned above. I can tell you that in resolving that issue, it did not fix this issue. This is due to the way Top Posts are retrieved from the server.

Issue 1:
The Top Posts endpoint on the REST API does not support filtering by post type. So if the widget is setup to view the top posts of a not-often-viewed custom post type, those posts might be low on the overall list. Meaning, it possibly could not show up on the retrieved list of 10 or so posts. You could try reconnecting and retrieving more posts, but it would be better to fix it on the server end, in my opinion.

Issue 2:
In addition, the REST endpoint restricts the max number of posts per day and doesn't retrieve an overall list of top posts. This probability won't affect most sites with the default option of top posts over 2 days, but if a site wants the top posts over a longer period, such as a month, this could allow a post that is visited more often over time to be cut off by posts that were only popular for a short time.

After looking through the public-api code, to fix the first issue would require a change to the select statement used to retrieve the list to something like SELECT from $pageviews_table JOIN $site_posts_table WHERE post_type IN ($post_types). However, for the second issue, the select statement is more complex with either a temp table or UNION ALL needed to collect a full list of posts. Of course, you could always run multiple select statements, merge the results, and filter using PHP as well. But I don't have the full view of how the database structure of WP.com is setup so there might be an easier way,

[jeherve]

Also reported here:
https://wordpress.org/support/topic/top-posts-category-filter-top-posts-limit-question?replies=1&view=all

[csonnek]

Also reported here:
https://wordpress.org/support/topic/popular-posts-widgets?replies=1

[jeherve]

Also reported here:
https://wordpress.org/support/topic/popular-posts-shortcode-display-count/

[jeherve]

Also reported here:
https://wordpress.org/support/topic/bug-jetpack-top-posts-pages-of-posts-displayed-incorrect/

[lschuyler]

Reported in 3165769-t

[AndreaBarghigiani]

I really appreciate all the work that this community is doing in order to improve the plugin, but I have a doubt: is this issue fixed?

I am asking because as reading from here it should be fixed by the 4.4 version and now we're running the 5.1 but I still have the same problem.

I still have to try the fix proposed by @t22james from this topic on, but before I do it I would like to understand a bit more what is going on.

Can we help the team testing some code? Shall we use the solution already proposed?

I am asking because I think this is a bug that needs to be fixed because otherwise, we as developers will have a problem working with this widget, especially if we have clients that need some sort of "top post by category".

I already tried to load more posts and then filter them out, but it does not assure to have a fixed number of posts inside our list.

Sometime the list could be even empty and it's difficult to understand how to run a check to hide the title widget if the list is empty.

Thank you for your hard work and for the support as well.

Talk you soon,
Andrea

[jeherve]

is this issue fixed?

No, this issue is still open, we don't have any perfect solution yet, so nothing for you to test either. We'll update this issue once we have some news!

[Ipstenu]

Yep, still an issue.

If Jetpack an detect the number of public post types, then why not just collect a number of posts (per the widget) and multiply it by the available post types.

So if I have posts, pages, and portfolios, and my widget is set to show the top 5, then it would collect 15 posts.

[jeherve]

Related: 7973-wpcom

[tmmbecker]

also reported here 1006113-zen
1930-gh-jpop-issues

[jeherve]

Another report in #11235 (cc @bsugerman)

[macmanx2]

This appears to be a variation of this bug: https://wordpress.org/support/topic/bug-popular-posts-and-pages-widget/

[nardbyte]

This appears to be a variation of this bug: https://wordpress.org/support/topic/bug-popular-posts-and-pages-widget/

Thanks for your reply, let me check the code, i go try fix it and i say here.

[darnelldibbles-zz]

Another report here:
https://wordpress.org/support/topic/top-posts-widget-not-working-correctly/

[ntpixels]

Also reported by 2471335-zen

[jeherve]

This should be fixed as of #15109.