Unofficial Sharing buttons don't point to the right URL when using "Page Links To" plugin

[richardmtl]

As reported in http://wordpress.org/support/topic/jetpack-sharing-module-issue-with-non-official-buttons?replies=6

If I use Jaquith's Page Links To plugin, and I try the unofficial sharing buttons, the sharing action doesn't work; I get a popup window with the Linked-to page, instead of a Facebook sharing dialogue that allows me to share the Linked-to page. However, it works as expected with the Official buttons: the shared URL is the linked-to URL. Also, as noted by the OP, other sharing plugins also work as expected, sharing the linked-to URL.

[jeherve]

The Page Links To plugin changes the post permalink value thanks to the post_link filter that is applied to the permalink URL for a post prior to returning the processed url by the function get_permalink(). Jetpack uses get_permalink() to build the sharing pop up, so that popup is broken.

We should be able to fix the problem by adding the correct URL back to the sharing module thanks to the sharing_display_link filter (#), but to do so we need to find a way to get the original post link without using get_permalink().

Looking into this a bit more.

For reference:

• https://github.com/markjaquith/page-links-to/blob/master/page-links-to.php#L69
• https://github.com/markjaquith/page-links-to/blob/master/page-links-to.php#L37

[georgestephanis]

If it's a single page, we could just do an add_query_arg() call without supplying the base URL, so it would just be added to current. The tricky bit is getting the links for archive pages.

Honestly, I'm unsure if it would be wisest to just call it a 'known issue' and 'wontfix' -- or whether we should change the urls we link to, to something like the super-raw /index.php?p=12345&share_to=facebook -- or whatever the specific args may be. Unsure.

@markjaquith -- your thoughts?

[stale]

This issue has been marked as stale. This happened because:

• It has been inactive in the past 6 months.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

[chickenn00dle]

Looks like this issue still persists. Tested with JP 7.8

Adding steps to reproduce just for convenience:

1. Install Page Links to plugin
2. Ensure Jetpack is active and connected
3. Create a Post or Page
4. Check the Custom Permalink in Post/Page settings and enter any URL
5. Go to Jetpack > Settings > Sharing > Sharing Buttons
6. Make sure this option is toggled on and select "Configure Sharing Buttons"
7. Select a button style other than "Official Buttons"
8. Make sure the "Front Page, Archive Pages, and Search Results" button is selected for Show like and sharing buttons on
9. Go to your homepage, and select any of the sharing buttons for the created post. You will get something like this:

[stale]

This issue has been marked as stale. This happened because:

• It has been inactive in the past 6 months.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

[github-actions]

This issue has been marked as stale. This happened because:

• It has been inactive in the past 6 months.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.