Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 1.19 plz~ #26

Open
FudgeDumbo opened this issue Jun 11, 2022 · 12 comments
Open

update 1.19 plz~ #26

FudgeDumbo opened this issue Jun 11, 2022 · 12 comments

Comments

@FudgeDumbo
Copy link

update 1.19 plz~ love your mod!

@candy999
Copy link

MO TOO~~

@soshimee
Copy link

This is an amazing mod, and we need it for 1.19.

@candy999
Copy link

This is the author's twitter, hopefully someone can try to get in touch.

https://twitter.com/axer_yok

@nakanotti
Copy link

とりあえずfabricだけでいいやと思って、解らないなりに、gradle wrapperして
build.gradle の fabric-loomを0.12-SHANPSHOTにして
mappings minecraft.officialMojangMappings() をloomのモノに変えて、
$ gradle migrateMappings --mappings "net.fabricmc:yarn:1.19+build.4" --input ../src/main/java --output ../src/main/java
でマッピング更新した上で、名前空間かなり変わっているので、適宜内容修正して、
gradle.propertiesも

# Done to increase the memory available to gradle.
org.gradle.jvmargs=-Xmx1G

# Fabric Properties
	# check these on https://fabricmc.net/develop
	minecraft_version=1.19
	yarn_mappings=1.19+build.4
	loader_version=0.14.8

# Mod Properties
	mod_version = 4.0.5
	maven_group = jp.axer.cocoainput
	archives_base_name = CocoaInput-1.19-fabric

# Dependencies
	fabric_version=0.56.1+1.19
	modmenu_version=4.0.0

こんな感じで最新化してビルドしたら、沢山エラーが出たのでふて寝しました。(笑)
お気持ちだけ匿名で寄付済みなので、果報を寝て待つしかない。(涙)

@candy999
Copy link

candy999 commented Jun 21, 2022

we may need self-help
fix JDK17 error:

General error during conversion: Unsupported class file major version 61

edit fabric\gradle\wrapper\gradle-wrapper.properties

distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip

to

distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-bin.zip

try gradlew.bat build
At this time, try 1.18 and it can be compiled
After confirming that the environment is normal

edit gradle.properties

# Done to increase the memory available to gradle.
org.gradle.jvmargs=-Xmx1G

# Fabric Properties
	# check these on https://fabricmc.net/use
minecraft_version=1.19
yarn_mappings=1.19+build.4
loader_version=0.14.8

# Mod Properties
	mod_version = 4.0.4
	maven_group = jp.axer.cocoainput
	archives_base_name = CocoaInput-1.19-fabric

# Dependencies
	modmenu_version=4.0.0

#Fabric api
fabric_version=0.56.1+1.19

1.19 requires fabric-loom 0.12
0.12 not have 'mappings minecraft.officialMojangMappings()'
change to 'mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"'
edit build.gradle

plugins {
	id 'fabric-loom' version '0.12-SNAPSHOT'
	id 'maven-publish'
}
....
dependencies {
	// To change the versions see the gradle.properties file
	minecraft "com.mojang:minecraft:${project.minecraft_version}"
	//mappings minecraft.officialMojangMappings()
	mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"
	// Fabric API. This is technically optional, but you probably want it anyway.
....

try gradlew.bat build
get error...

C:\Users\Administrator\Desktop\CocoaInput-master\CocoaInput-master\src\fabric\java\jp\axer\cocoainput\mixin\MinecraftMixin.java:12: error: cannot find symbol
@Mixin(Minecraft.class)
       ^
  symbol: class Minecraft
70 errors
2 warnings
Deprecated Loom APIs were used in this build, making it incompatible with future versions of Loom. Use Gradle warning modes to control the verbosity of the warnings.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
1 actionable task: 1 executed

Can someone relay the fix?

@kgamecarter
Copy link

plz update 1.19 😭

@candy999 candy999 mentioned this issue Jun 22, 2022
@nakanotti
Copy link

<build.gradle>

//mappings minecraft.officialMojangMappings()
mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"

maybe...

	//mappings minecraft.officialMojangMappings()
	mappings loom.officialMojangMappings()

@nakanotti
Copy link

nakanotti commented Jun 22, 2022

import net.minecraft.network.chat.BaseComponent;
import net.minecraft.network.chat.TextComponent;
import net.minecraft.network.chat.TranslatableComponent;

この辺が失われているみたい。
無理やり他の型に置き換えてみました。

//import net.minecraft.network.chat.BaseComponent;
//import net.minecraft.network.chat.TextComponent;
//import net.minecraft.network.chat.TranslatableComponent;
import net.minecraft.network.chat.contents.TranslatableContents;
import net.minecraft.network.chat.MutableComponent;
 :
new TranslatableComponent(str) こんなコードは
MutableComponent.create(new TranslatableContents(str)) こんな感じにむりやり置き換えた

とりあえず、ビルドはできた。
取れない警告は1個

CocoaInput\src\main\java\jp\axer\cocoainput\mixin\SharedConstantsMixin.java:14: 警告:@Overwrite is missing javadoc comment
        public static boolean isAllowedChatCharacter(char p) {

案の定、起動時にクラッシュ。

@nakanotti
Copy link

nakanotti commented Jun 22, 2022

とりあえず動いたので、試したい方はどうぞ。(必ず正規版をお待ちください。)

CocoaInput-1.19-fabric-4.0.5-SNAPSHOT.jar.zip (old)

(jarをzip化…腹痛が痛いw)

new version: #26 (comment)

@soshimee
Copy link

Amazing update at 4 a.m. also yeah jar in a zip lol. Seems to work fine this far!

@nakanotti
Copy link

修正が正しいか不安なので、差分が見れる状態にしておきました。
nakanotti#1
@Axeryok もしもコードレビューしていただけるのであれば、こちらにプルリクエストさせていただきます。

@candy999
Copy link

@nakanottiの貢献に感謝します💕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants