Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Confirm view: Add error or informative message when "Confirmar Recepcion" button fails #153

Closed
1 task
heliomar-pena opened this issue Nov 16, 2021 · 11 comments · Fixed by #192
Closed
1 task
Assignees
Labels
EE-3 Estimation Effort 3

Comments

@heliomar-pena
Copy link
Collaborator

heliomar-pena commented Nov 16, 2021

Explication

In confirm view (https://dev--azordev-dasher-user.netlify.app/confirm/902b7f07-da34-4ab5-9a8c-d9db03ba55b5) when user clicks confirm button and the package is already confirmed before, any action occurs, please add one message error or informative to say this to the user

Screenshots

imagen

Checklist

This issue can be closed when the following tasks are complete:

  • When package can't be confirmed, please show a message explaining what is the problem
@e-azocar e-azocar self-assigned this Nov 17, 2021
@e-azocar
Copy link
Contributor

e-azocar commented Nov 17, 2021

What's the name, RUT and phone number that i need for confirm?

@Israel-Laguan
Copy link
Collaborator

What's the name, RUT, and phone number that I need to confirm?

Its extra info the client knows, but in fact we only check RUT

@Israel-Laguan
Copy link
Collaborator

Confirm with @angelik0828 about the style for errors

@heliomar-pena
Copy link
Collaborator Author

@Israel-Laguan I think that the question is what is the information that we need put in the form to confirm that we have receive the package.

I remember that the test package have your data:

Nombre: Israel Laguan
RUT: ???
Celular: ???

Can you provide this information to @e-azocar can see the problem of this issue in local ?

@heliomar-pena heliomar-pena added the EE-3 Estimation Effort 3 label Nov 24, 2021
@Israel-Laguan
Copy link
Collaborator

Can you provide this information to @e-azocar can see the problem of this issue in local ?

I can sync up with @e-azocar on this next meeting

@angelik0828
Copy link

Rut = unique identity document in Chile, for companies and individuals, refers to a unique tax role.

@angelik0828
Copy link

When the user fills out the form, it is better to perform the validation before sending the data so we reduce errors, we can add a validator in each text field or a check and we use the pop-up window for the correct delivery validation. What do you think?
https://www.figma.com/file/tbhMgDT10bbVjB9GazF97y/Untitled?node-id=0%3A1

@heliomar-pena
Copy link
Collaborator Author

Other error to validate is when the package doesn't exists on the database. I notice that at the URL you can pass 'cualquier cosa'

imagen

and doesn't exists previous validation

@Israel-Laguan
Copy link
Collaborator

we can add a validator in each text field or a check

Yes, what would an error message look like?

@angelik0828
Copy link

Updated bugs in figma link including the BD, tell me please.

@Israel-Laguan
Copy link
Collaborator

I left a question on the design @angelik0828, please check

e-azocar added a commit that referenced this issue Jan 11, 2022
Added modal to show error message
e-azocar added a commit that referenced this issue Jan 12, 2022
heliomar-pena added a commit that referenced this issue Jan 12, 2022
Added validation before package confirm
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EE-3 Estimation Effort 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants