Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Simulator crash when there is a user join with camera on randomly #408

Open
AmyL219 opened this issue Oct 29, 2021 · 1 comment
Open
Labels
Bug Something isn't working Needs: triage 🔍

Comments

@AmyL219
Copy link

AmyL219 commented Oct 29, 2021

Describe the bug
1.Join in a group call through simulator
2.Use web/app to join the same group call with camera on as a new participant
3.Find the SwiftUI app could crash in AVMakeRectWithAspectRatioFill(CGSize,int) function

Expected behavior
Simulator shouldn't crash

Screenshots

Screen Shot 2021-10-28 at 10 56 55 AM

iOS SDK version:

  • 2.0.1-beta 1
    Xcode version:
  • 13.1
    Simulator version:
  • iOS 15
@AmyL219 AmyL219 added the Bug Something isn't working label Oct 29, 2021
@ghost ghost added the Needs: triage 🔍 label Oct 29, 2021
@AmyL219
Copy link
Author

AmyL219 commented Nov 2, 2021

https://skype.visualstudio.com/SPOOL/_workitems/edit/2629990

Did some debugging and found the crash issues is because of the rendererView is created by scalingMode: .crop with the SwiftUI env. CallingSDK testing app use .fit mode, so their app didn't crash. But after changing the testing app scalingMode into crop, it eventually crashed at same place. (See the attachment pic)
If we changed our composite rendererView creation to non-option mode (which make it default to be .fit mode), there is no more composite crash in simulator any more. But the view may not fit the designer requirement.

Screen Shot 2021-11-01 at 11 25 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs: triage 🔍
Projects
None yet
Development

No branches or pull requests

1 participant