Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structured data support with GitHub secrets #77

Open
melscoop opened this issue Jul 8, 2021 · 0 comments
Open

structured data support with GitHub secrets #77

melscoop opened this issue Jul 8, 2021 · 0 comments

Comments

@melscoop
Copy link

melscoop commented Jul 8, 2021

👋 Hi all - the following document suggested storing Azure credentials as a secret in JSON format.

https://github.com/Azure/actions-workflow-samples/blob/master/assets/create-secrets-for-GitHub-workflows.md#set-secret-with-azure-credentials

Store the above JSON as the value of a GitHub secret with a name, for example 'AZURE_CREDENTIALS'

Unfortunately this information is incorrect, as GitHub does not support JSON or any structured data for secrets.

https://docs.github.com/en/actions/reference/encrypted-secrets#naming-your-secrets

To help ensure that GitHub redacts your secret in logs, avoid using structured data as the values of secrets. For example, avoid creating secrets that contain JSON or encoded Git blobs.

Could someone please update the document to reflect these limitations. Thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant