Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple logic error in FileUploadNotificationReceiverSample.cs - inverted check for null #3369

Closed
jeffvan98 opened this issue Sep 15, 2023 · 1 comment · Fixed by #3371
Closed
Assignees
Labels
bug Something isn't working. IoTSDK Tracks all IoT SDK issues across the board

Comments

@jeffvan98
Copy link

See FileUploadNotificationReceiverSample.cs, line 83:

83: if (fileUploadNotification != null)
84: {
85: _logger.LogInformation("Did not receive any notification.");
86: continue;
87: }

The if statement is backwards. It should read: if (fileUploadNotification == null).

The way its programmed, file notifications don't make it through this if block and therefore never get completed. This needs to be flipped so the subsequent logic may proceed and complete the notifications.

@jeffvan98 jeffvan98 added the bug Something isn't working. label Sep 15, 2023
@github-actions github-actions bot added the IoTSDK Tracks all IoT SDK issues across the board label Sep 15, 2023
@timtay-microsoft
Copy link
Member

Thanks for catching this. #3371 will address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. IoTSDK Tracks all IoT SDK issues across the board
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants