New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the admin account requirement for Docker login action #38

Open

BALAGA-GAYATRI opened this issue May 17, 2022 · 0 comments

Labels

Contributor

BALAGA-GAYATRI commented May 17, 2022

This action currently requires an admin account to push images to an Azure Container Registry, which requires customers to enable the admin account when deploying to ACR with GitHub Actions. Enabling such an account is not recommended per the least privilege principle, and it is an https://github.com/Azure/docker-login/issues/34that needs to be managed.

It should be possible to use Azure Credentials for ACR logins.

Follow the instructions on GitHub - Azure/docker-login: GitHub action to log in to Azure Container Registry (ACR) or any private container registry: --> the instructions require an admin account, which is not recommended.

A better alternative is to use Azure credentials, especially if the workflow is already using the azure/login task.

BALAGA-GAYATRI added the need-to-triage label

lgmorand added enhancement and removed need-to-triage labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment