Add visibility modifiers for each functions

Summary: Reduce lint warnings

Reviewers: barath

Reviewed By: barath

Differential Revision: https://phabricator.bitgo.com/D7175

Author: OttoAllmendinger

contracts/ERC20Interface.sol

@@ -5,7 +5,7 @@ pragma solidity ^0.4.11;
 
 contract ERC20Interface {
   // Send _value amount of tokens to address _to
-  function transfer(address _to, uint256 _value) returns (bool success);
+  function transfer(address _to, uint256 _value) public returns (bool success);
   // Get the account balance of another account with address _owner
-  function balanceOf(address _owner) constant returns (uint256 balance);
+  function balanceOf(address _owner) public constant returns (uint256 balance);
 }

contracts/FixedSupplyToken.sol

@@ -9,24 +9,24 @@ pragma solidity ^0.4.11;
 // https://github.com/ethereum/EIPs/issues/20
 contract ERC20Interface {
   // Get the total token supply
-  function totalSupply() constant returns (uint256 totalSupply);
+  function totalSupply() public constant returns (uint256 totalSupply);
 
   // Get the account balance of another account with address _owner
-  function balanceOf(address _owner) constant returns (uint256 balance);
+  function balanceOf(address _owner) public constant returns (uint256 balance);
 
   // Send _value amount of tokens to address _to
-  function transfer(address _to, uint256 _value) returns (bool success);
+  function transfer(address _to, uint256 _value) public returns (bool success);
 
   // Send _value amount of tokens from address _from to address _to
-  function transferFrom(address _from, address _to, uint256 _value) returns (bool success);
+  function transferFrom(address _from, address _to, uint256 _value) public returns (bool success);
 
   // Allow _spender to withdraw from your account, multiple times, up to the _value amount.
   // If this function is called again it overwrites the current allowance with _value.
   // this function is required for some DEX functionality
-  function approve(address _spender, uint256 _value) returns (bool success);
+  function approve(address _spender, uint256 _value) public returns (bool success);
 
   // Returns the amount which _spender is still allowed to withdraw from _owner
-  function allowance(address _owner, address _spender) constant returns (uint256 remaining);
+  function allowance(address _owner, address _spender) public constant returns (uint256 remaining);
 
   // Triggered when tokens are transferred.
   event Transfer(address indexed _from, address indexed _to, uint256 _value);
@@ -59,22 +59,22 @@ contract FixedSupplyToken is ERC20Interface {
   }
 
   // Constructor
-  function FixedSupplyToken() {
+  function FixedSupplyToken() public {
     owner = msg.sender;
     balances[owner] = _totalSupply;
   }
 
-  function totalSupply() constant returns (uint256 totalSupply) {
+  function totalSupply() public constant returns (uint256 totalSupply) {
     totalSupply = _totalSupply;
   }
 
   // What is the balance of a particular account?
-  function balanceOf(address _owner) constant returns (uint256 balance) {
+  function balanceOf(address _owner) public constant returns (uint256 balance) {
     return balances[_owner];
   }
 
   // Transfer the balance from owner's account to another account
-  function transfer(address _to, uint256 _amount) returns (bool success) {
+  function transfer(address _to, uint256 _amount) public returns (bool success) {
     if (balances[msg.sender] >= _amount && _amount > 0 && balances[_to] + _amount > balances[_to]) {
       balances[msg.sender] -= _amount;
       balances[_to] += _amount;
@@ -95,7 +95,7 @@ contract FixedSupplyToken is ERC20Interface {
       address _from,
       address _to,
       uint256 _amount
-  ) returns (bool success) {
+  ) public returns (bool success) {
     if (balances[_from] >= _amount && allowed[_from][msg.sender] >= _amount && _amount > 0 && balances[_to] + _amount > balances[_to]) {
        balances[_from] -= _amount;
        allowed[_from][msg.sender] -= _amount;
@@ -109,13 +109,13 @@ contract FixedSupplyToken is ERC20Interface {
 
   // Allow _spender to withdraw from your account, multiple times, up to the _value amount.
   // If this function is called again it overwrites the current allowance with _value.
-  function approve(address _spender, uint256 _amount) returns (bool success) {
+  function approve(address _spender, uint256 _amount) public returns (bool success) {
     allowed[msg.sender][_spender] = _amount;
     Approval(msg.sender, _spender, _amount);
     return true;
   }
 
-  function allowance(address _owner, address _spender) constant returns (uint256 remaining) {
+  function allowance(address _owner, address _spender) public constant returns (uint256 remaining) {
     return allowed[_owner][_spender];
   }
 }

contracts/Forwarder.sol

@@ -11,25 +11,26 @@ contract Forwarder {
   /**
    * Create the contract, and set the destination address to `target`
    */
-  function Forwarder(address target) {
+  function Forwarder(address target) public {
     targetAddress = target;
   }
 
   /**
    * Default function; Gets called when Ether is deposited, and forwards it to the target address
    */
-  function() payable {
-    if (!targetAddress.call.value(msg.value)(msg.data))
+  function() public payable {
+    if (!targetAddress.call.value(msg.value)(msg.data)) {
       throw;
-    // Fire off the deposited event if we can forward it  
+    }
+    // Fire off the deposited event if we can forward it
     ForwarderDeposited(msg.sender, msg.value, msg.data);
   }
 
   /**
    * Execute a token transfer of the full balance from the forwarder token to the target address
    * @param tokenContractAddress the address of the erc20 token contract
    */
-  function flushTokens(address tokenContractAddress) {
+  function flushTokens(address tokenContractAddress) public {
     ERC20Interface instance = ERC20Interface(tokenContractAddress);
     var forwarderAddress = address(this);
     var forwarderBalance = instance.balanceOf(forwarderAddress);
@@ -45,8 +46,9 @@ contract Forwarder {
    * It is possible that funds were sent to this address before the contract was deployed.
    * We can flush those funds to the target address.
    */
-  function flush() {
-    if (!targetAddress.call.value(this.balance)())
+  function flush() public {
+    if (!targetAddress.call.value(this.balance)()) {
       throw;
+    }
   }
 }

contracts/WalletSimple.sol

@@ -44,7 +44,7 @@ contract WalletSimple {
    *
    * @param allowedSigners An array of signers on the wallet
    */
-  function WalletSimple(address[] allowedSigners) {
+  function WalletSimple(address[] allowedSigners) public {
     if (allowedSigners.length != 3) {
       // Invalid number of signers
       throw;
@@ -55,7 +55,7 @@ contract WalletSimple {
   /**
    * Gets called when a transaction is received without calling a method
    */
-  function() payable {
+  function() public payable {
     if (msg.value > 0) {
       // Fire deposited event if we are receiving funds
       Deposited(msg.sender, msg.value, msg.data);
@@ -74,7 +74,14 @@ contract WalletSimple {
    * @param sequenceId the unique sequence id obtainable from getNextSequenceId
    * @param signature the result of eth.sign on the operationHash sha3(toAddress, value, data, expireTime, sequenceId)
    */
-  function sendMultiSig(address toAddress, uint value, bytes data, uint expireTime, uint sequenceId, bytes signature) onlysigner {
+  function sendMultiSig(
+      address toAddress,
+      uint value,
+      bytes data,
+      uint expireTime,
+      uint sequenceId,
+      bytes signature
+  ) public onlysigner {
     // Verify the other signer
     var operationHash = sha3("ETHER", toAddress, value, data, expireTime, sequenceId);
 
@@ -100,7 +107,14 @@ contract WalletSimple {
    * @param sequenceId the unique sequence id obtainable from getNextSequenceId
    * @param signature the result of eth.sign on the operationHash sha3(toAddress, value, tokenContractAddress, expireTime, sequenceId)
    */
-  function sendMultiSigToken(address toAddress, uint value, address tokenContractAddress, uint expireTime, uint sequenceId, bytes signature) onlysigner {
+  function sendMultiSigToken(
+      address toAddress,
+      uint value,
+      address tokenContractAddress,
+      uint expireTime,
+      uint sequenceId,
+      bytes signature
+  ) public onlysigner {
     // Verify the other signer
     var operationHash = sha3("ERC20", toAddress, value, tokenContractAddress, expireTime, sequenceId);
 
@@ -122,7 +136,13 @@ contract WalletSimple {
    * @param sequenceId the unique sequence id obtainable from getNextSequenceId
    * returns address of the address to send tokens or eth to
    */
-  function verifyMultiSig(address toAddress, bytes32 operationHash, bytes signature, uint expireTime, uint sequenceId) private returns (address) {
+  function verifyMultiSig(
+      address toAddress,
+      bytes32 operationHash,
+      bytes signature,
+      uint expireTime,
+      uint sequenceId
+  ) private returns (address) {
 
     var otherSigner = recoverAddressFromSignature(operationHash, signature);
 
@@ -155,7 +175,7 @@ contract WalletSimple {
   /**
    * Irrevocably puts contract into safe mode. When in this mode, transactions may only be sent to signing addresses.
    */
-  function activateSafeMode() onlysigner {
+  function activateSafeMode() public onlysigner {
     safeMode = true;
     SafeModeActivated(msg.sender);
   }
@@ -165,7 +185,7 @@ contract WalletSimple {
    * @param signer address to check
    * returns boolean indicating whether address is signer or not
    */
-  function isSigner(address signer) returns (bool) {
+  function isSigner(address signer) public view returns (bool) {
     // Iterate through all signers on the wallet and
     for (uint i = 0; i < signers.length; i++) {
       if (signers[i] == signer) {
@@ -181,7 +201,10 @@ contract WalletSimple {
    * @param signature the tightly packed signature of r, s, and v as an array of 65 bytes (returned by eth.sign)
    * returns address recovered from the signature
    */
-  function recoverAddressFromSignature(bytes32 operationHash, bytes signature) private returns (address) {
+  function recoverAddressFromSignature(
+    bytes32 operationHash,
+    bytes signature
+  ) private pure returns (address) {
     if (signature.length != 65) {
       throw;
     }
@@ -206,7 +229,7 @@ contract WalletSimple {
    * greater than the minimum element in the window.
    * @param sequenceId to insert into array of stored ids
    */
-  function tryInsertSequenceId(uint sequenceId) onlysigner private {
+  function tryInsertSequenceId(uint sequenceId) private onlysigner {
     // Keep a pointer to the lowest value element in the window
     uint lowestValueIndex = 0;
     for (uint i = 0; i < SEQUENCE_ID_WINDOW_SIZE; i++) {
@@ -235,7 +258,7 @@ contract WalletSimple {
    * Gets the next available sequence ID for signing when using executeAndConfirm
    * returns the sequenceId one higher than the highest currently stored
    */
-  function getNextSequenceId() returns (uint) {
+  function getNextSequenceId() public view returns (uint) {
     uint highestSequenceId = 0;
     for (uint i = 0; i < SEQUENCE_ID_WINDOW_SIZE; i++) {
       if (recentSequenceIds[i] > highestSequenceId) {