Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"404" page is actually a 500 #121

Open
wmorgan opened this issue Oct 20, 2021 · 2 comments
Open

"404" page is actually a 500 #121

wmorgan opened this issue Oct 20, 2021 · 2 comments

Comments

@wmorgan
Copy link
Contributor

wmorgan commented Oct 20, 2021

The failure page (e.g. when donut is clicked) has the text "404" in it, but this is actually a 500 response.

@olix0r
Copy link
Member

olix0r commented Oct 20, 2021

Presumably this is because linkerd only counts 5xx as failures. Should we just remove the 404 text to say "an error has occurred"?

@wmorgan
Copy link
Contributor Author

wmorgan commented Oct 20, 2021

Yes, I think that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants