Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive update and cancellation of spatial profiler generation (backend) #1179

Open
kswang1029 opened this issue Aug 4, 2022 · 4 comments
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Aug 4, 2022

user feedback from v3 beta test

Similar to the progressive update and cancellation features in the spectral profiler widget, the spatial profiler widget should also have the same features as a visual indication of the progress for better UX.

The companion frontend issue is CARTAvis/carta-frontend#1954

@veggiesaurus
Copy link
Collaborator

it's not really clear to me why this is needed... shouldn't this be extremely quick?

@kswang1029
Copy link
Contributor Author

it's not really clear to me why this is needed... shouldn't this be extremely quick?

it is not. Sometimes it takes quite some time to get a spatial profile. The underlying reason is not clear. @pford do you know where the bottleneck is?

@veggiesaurus
Copy link
Collaborator

we normally have the data in memory, but I guess if we're using casacore it tries to load things again.

@kswang1029 kswang1029 added the requiring frontend this backend issue requires work in both frontend and backend label Aug 4, 2022
@pford
Copy link
Collaborator

pford commented Aug 4, 2022

I assume this is for region spatial profiles. The default region is 'Active', so if the user creates a region the profile widget clears the cursor profile. Region spatial profiles are only valid for point, line, and polyline, so if the active region is another type the profile is not generated and the widget remains blank. (I think the frontend should not clear and request a spatial profile for a non-valid region type.)

If the region is a line, the backend response is the same as for the PV generator, creating box regions along the line and getting stats (the mean) for each box for the current channel. This could take some time if there are many boxes, if the image requires fixed angular spacing, or if the line is a matched region and each box must be converted from the reference image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
No open projects
Status: Icebox
Status: Icebox
Development

No branches or pull requests

3 participants