Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stats type NanCount #161

Open
pford opened this issue Apr 4, 2019 · 8 comments
Open

Support stats type NanCount #161

pford opened this issue Apr 4, 2019 · 8 comments
Assignees
Labels
requiring frontend this backend issue requires work in both frontend and backend

Comments

@pford
Copy link
Collaborator

pford commented Apr 4, 2019

For CyberSKA requirement, no corresponding stat in casacore.

@ChristyReynolds ChristyReynolds self-assigned this Apr 4, 2019
@veggiesaurus
Copy link
Collaborator

@arusstaylor can you comment on whether this is essential? Haven't seen a NaN count statistic in viewers other than CyberSKA before.

@arusstaylor
Copy link

arusstaylor commented Apr 5, 2019 via email

@veggiesaurus
Copy link
Collaborator

@pford I believe the cassacore pixel count excludes NaNs at this point. Should we close this issue then?

@arusstaylor
Copy link

arusstaylor commented Apr 5, 2019 via email

@pford
Copy link
Collaborator Author

pford commented Apr 5, 2019

Yes, NumPixels excludes NaNs. Will close. This CARTA::StatType should be removed from the ICD.

@pford pford closed this as completed Apr 5, 2019
@pford pford reopened this Apr 24, 2019
@pford pford added this to the Version 1.2 milestone Apr 24, 2019
@pford pford assigned pford and unassigned ChristyReynolds Apr 25, 2019
@pford
Copy link
Collaborator Author

pford commented Apr 25, 2019

Needed for release 1.2 based on testing feedback.

@pford pford assigned pford and ChristyReynolds and unassigned pford May 1, 2019
@Kechil Kechil removed this from the Version 1.2 milestone Jul 24, 2019
@pford
Copy link
Collaborator Author

pford commented Aug 15, 2019

As I understand it, this is extremely difficult in casacore. Images are masked so that unmasked pixels may be used for calculations, which means that for a region, a pixel may be masked because it is NaN, it is outside the region, or both. Therefore impossible to count "in the region but value is NaN".

@veggiesaurus
Copy link
Collaborator

@pford I guess we can icebox this for now then

@kswang1029 kswang1029 added the requiring frontend this backend issue requires work in both frontend and backend label Nov 19, 2020
@kswang1029 kswang1029 added this to CARTA Dec 6, 2023
@kswang1029 kswang1029 moved this to Icebox in CARTA Dec 6, 2023
@github-project-automation github-project-automation bot moved this to New issues/PRs in CARTA - backend Dec 14, 2023
@kswang1029 kswang1029 moved this from New issues/PRs to Icebox in CARTA - backend Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requiring frontend this backend issue requires work in both frontend and backend
Projects
No open projects
Status: Icebox
Status: Icebox
Development

No branches or pull requests

6 participants