-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support stats type NanCount #161
Comments
@arusstaylor can you comment on whether this is essential? Haven't seen a NaN count statistic in viewers other than CyberSKA before. |
I don’t think this is essential as long as the pixel count does not include Nans.
Russ
…Sent from my iPad
On 05 Apr 2019, at 07:41, Angus Comrie ***@***.***> wrote:
@arusstaylor can you comment on whether this is essential? Haven't seen a NaN count statistic in viewers other than CyberSKA before.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@pford I believe the cassacore pixel count excludes NaNs at this point. Should we close this issue then? |
Fine with me to close.
Russ
… On 05 Apr 2019, at 09:55, Angus Comrie ***@***.***> wrote:
@pford <https://github.com/pford> I believe the cassacore pixel count excludes NaNs at this point. Should we close this issue then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#161 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIotLWBeRBLVifLmmvX1fDZZz9xAOkzgks5vdwF2gaJpZM4cc9Ps>.
|
Yes, NumPixels excludes NaNs. Will close. This CARTA::StatType should be removed from the ICD. |
Needed for release 1.2 based on testing feedback. |
As I understand it, this is extremely difficult in casacore. Images are masked so that unmasked pixels may be used for calculations, which means that for a region, a pixel may be masked because it is NaN, it is outside the region, or both. Therefore impossible to count "in the region but value is NaN". |
@pford I guess we can icebox this for now then |
For CyberSKA requirement, no corresponding stat in casacore.
The text was updated successfully, but these errors were encountered: