Is it superuser or admin?

[mehov]

Is there a difference between superuser and admin?

users/src/Model/Table/UsersTable.php

Lines 45 to 46 in 9f9f49b

	public const ROLE_USER = 'user';
	public const ROLE_ADMIN = 'admin';

users/src/Command/UsersAddSuperuserCommand.php

Lines 27 to 31 in 9f9f49b

	$this->_createUser($args, $io, [
	'username' => 'superadmin',
	'role' => 'superuser',
	'is_superuser' => true,
	]);

If not, it will probably be more consistent if UsersAddSuperuserCommand reuses the role defined in UsersTable instead of hardcoding superuser. This way we can always read whatever the super-user-admin role name is by calling \CakeDC\Users\Model\Table\UsersTable::ROLE_ADMIN.

UPDATE: Code search says that ROLE_ADMIN is not being used anywhere inside this plugin.

UPDATE According to blame, ROLE_ADMIN originates in ebe0114. Searching ROLE_ though commit source shows only 2 matches where the two constants are introduced, doesn't show any usage.