Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up CI jobs per OS #4604

Open
pajlada opened this issue May 6, 2023 · 1 comment
Open

Split up CI jobs per OS #4604

pajlada opened this issue May 6, 2023 · 1 comment
Labels
blocked Something out of our power needs to change before proceeding with this issue ci Issues related to the ci

Comments

@pajlada
Copy link
Member

pajlada commented May 6, 2023

All CI build jobs are currently in the same file.
While this reduces some code on shared steps, it makes testing artifacts more difficult and time-consuming, and makes it more difficult to add the ability to skip certain jobs for PRs.
The jobs should be split up as build-windows, build-linux, and build-macos.
We might be able to make our own 'release' local workflow that can be re-used, but if there has to be some duplicate structure, that is ok.

@pajlada pajlada added the ci Issues related to the ci label May 6, 2023
@pajlada pajlada added this to the 2.4.4 milestone May 6, 2023
@pajlada
Copy link
Member Author

pajlada commented May 7, 2023

Unfortunately, we have two issues that make this less worth doing.
A big motivation for this split would be that we'd be able to access artifacts before the build is finished, but that's not possible right now pending this feature request actions/upload-artifact#181

The alternative would be to have completely separate workflows (which was my first option), but then the release-creation becomes difficult because there's no way to fire off a workflow only once multiple workflows have succeeded pending this feature request https://github.com/orgs/community/discussions/16059

I will remove this from the milestone and mark it as blocked until one of the two features have been implemented.

@pajlada pajlada removed this from the 2.4.4 milestone May 7, 2023
@pajlada pajlada added the blocked Something out of our power needs to change before proceeding with this issue label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something out of our power needs to change before proceeding with this issue ci Issues related to the ci
Projects
None yet
Development

No branches or pull requests

1 participant