Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Benchmarks #4947

Open
6 tasks
Nerixyz opened this issue Nov 5, 2023 · 1 comment
Open
6 tasks

Improve Benchmarks #4947

Nerixyz opened this issue Nov 5, 2023 · 1 comment
Labels

Comments

@Nerixyz
Copy link
Contributor

Nerixyz commented Nov 5, 2023

This is some kind of meta issue. The goal is to improve the process of increasing Chatterino's performance and decreasing its resource usage. By having good benchmarks, identifying slow paths can become easier and the impact of different changes can be tracked.

  • Compile (not run) benchmarks in CI
  • Not really related to benchmarks but useful for new contributors: Document CMake options (as mentioned in Improve Benchmarks #4947 (comment), by adding more comments on option(..))
  • Add benchmark for TwitchMessageBuilder
  • Add benchmark for parsing of recent messages
  • Add benchmark for message layout (not 100% sure if this can be done yet; this needs tests as well)
  • Add benchmark for filters

Feel free to suggest more items.

@Nerixyz Nerixyz added the issue-report An issue reported by a user. label Nov 5, 2023
@pajlada pajlada added Refactor and removed issue-report An issue reported by a user. labels Nov 5, 2023
@pajlada
Copy link
Member

pajlada commented Nov 5, 2023

Not really related to benchmarks but useful for new contributors: Document CMake options

This should be documented by saying: "Open CMakeLists.txt and look at the top options", and potentially add better comments there.
If you are a new contributor looking to find out what options there are, you might as well know what a CMakeLists.txt file looks like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants