From 8a47602d26afbb2d57a0a3839cd761b31af58417 Mon Sep 17 00:00:00 2001 From: Josh Bowen Date: Fri, 3 Jun 2022 14:22:03 -0400 Subject: [PATCH 1/2] never close channel in subscribe --- rpc/json/service.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rpc/json/service.go b/rpc/json/service.go index 8c1f37485..54a160abe 100644 --- a/rpc/json/service.go +++ b/rpc/json/service.go @@ -130,9 +130,9 @@ func (s *service) Subscribe(req *http.Request, args *SubscribeArgs, wsConn *wsCo } s.logger.Error("subscription was cancelled", "reason", reason) } - if wsConn != nil { - close(wsConn.queue) - } + // if wsConn != nil { + // close(wsConn.queue) + // } return } } From 2df6392d966cff0473a669d593163c556e6159f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Zdyba=C5=82?= Date: Mon, 4 Jul 2022 22:37:01 +0200 Subject: [PATCH 2/2] Cleanup --- rpc/json/service.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/rpc/json/service.go b/rpc/json/service.go index 54a160abe..c5ab3eba8 100644 --- a/rpc/json/service.go +++ b/rpc/json/service.go @@ -130,9 +130,6 @@ func (s *service) Subscribe(req *http.Request, args *SubscribeArgs, wsConn *wsCo } s.logger.Error("subscription was cancelled", "reason", reason) } - // if wsConn != nil { - // close(wsConn.queue) - // } return } }