From 2ded3cf2bd5bbdb6d8e647e15cd82257192a8904 Mon Sep 17 00:00:00 2001 From: hxy1991 Date: Thu, 8 Nov 2018 15:39:07 +0800 Subject: [PATCH] Fixes #246 --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- .travis.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index fae0c624d63..ff44f63847a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,5 +18,5 @@ Follow this checklist to help us incorporate your contribution quickly and easil * [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. * [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. * [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/nacos/tree/master/test). -* [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. +* [ ] Run `mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. diff --git a/.travis.yml b/.travis.yml index 359ac0dbd68..b3a9f649724 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,7 +25,7 @@ before_install: - if [ "$TRAVIS_OS_NAME" == "linux" ]; then jdk_switcher use "$CUSTOM_JDK"; fi script: - - mvn -B clean apache-rat:check findbugs:findbugs + - mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true - mvn -Prelease-nacos clean install -U - mvn clean package -Pit-test after_success: