Move findfiles example into manual tests

The example follows bad and outdated practices: - running time consuming and I/O heavy workload in the GUI thread - calling processEvents to keep the UI responsive - showing results only at the end of a search rather than continuously Perhaps this example can be rewritten at some point to apply modern practices (at least use a thread and emit signals), but it seems to have low overall educational value. Moving it to be a manual test for now. Fixes: QTBUG-111002 Pick-to: 6.5 Change-Id: Id630fd4599096448ea4f96bcbf977b11a039796f Reviewed-by: Axel Spoerl <[email protected]> Reviewed-by: Qt CI Bot <[email protected]>
ClassAteam · Feb 8, 2023 · 3fe0bf6 · 3fe0bf6
1 parent 55f2b44
commit 3fe0bf6
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 3 deletions.
diff --git a/doc/src/images/findfiles-example.png b/doc/src/images/findfiles-example.png
diff --git a/examples/widgets/dialogs/CMakeLists.txt b/examples/widgets/dialogs/CMakeLists.txt
@@ -6,7 +6,6 @@ if(QT_FEATURE_wizard)
     qt_internal_add_example(trivialwizard)
 endif()
 qt_internal_add_example(extension)
-qt_internal_add_example(findfiles)
 qt_internal_add_example(standarddialogs)
 qt_internal_add_example(tabdialog)
 if(QT_FEATURE_wizard AND TARGET Qt6::PrintSupport)

diff --git a/examples/widgets/dialogs/dialogs.pro b/examples/widgets/dialogs/dialogs.pro
@@ -3,7 +3,6 @@ QT_FOR_CONFIG += widgets
 TEMPLATE      = subdirs
 SUBDIRS       = classwizard \
                 extension \
-                findfiles \
                 licensewizard \
                 standarddialogs \
                 tabdialog \

diff --git a/src/widgets/dialogs/qprogressdialog.cpp b/src/widgets/dialogs/qprogressdialog.cpp
@@ -215,7 +215,7 @@ void QProgressDialogPrivate::_q_disconnectOnClose()
 
   \image fusion-progressdialog.png A progress dialog shown in the Fusion widget style.
 
-  \sa QDialog, QProgressBar, {Find Files Example}, {Pixelator Example}
+  \sa QDialog, QProgressBar, {Pixelator Example}
 */
 
 

diff --git a/.../widgets/dialogs/findfiles/CMakeLists.txt → tests/manual/findfiles/CMakeLists.txt b/.../widgets/dialogs/findfiles/CMakeLists.txt → tests/manual/findfiles/CMakeLists.txt
diff --git a/...s/widgets/dialogs/findfiles/findfiles.pro → tests/manual/findfiles/findfiles.pro b/...s/widgets/dialogs/findfiles/findfiles.pro → tests/manual/findfiles/findfiles.pro
diff --git a/examples/widgets/doc/src/findfiles.qdoc → tests/manual/findfiles/findfiles.qdoc b/examples/widgets/doc/src/findfiles.qdoc → tests/manual/findfiles/findfiles.qdoc
diff --git a/examples/widgets/dialogs/findfiles/main.cpp → tests/manual/findfiles/main.cpp b/examples/widgets/dialogs/findfiles/main.cpp → tests/manual/findfiles/main.cpp
diff --git a/...ples/widgets/dialogs/findfiles/window.cpp → tests/manual/findfiles/window.cpp b/...ples/widgets/dialogs/findfiles/window.cpp → tests/manual/findfiles/window.cpp
diff --git a/examples/widgets/dialogs/findfiles/window.h → tests/manual/findfiles/window.h b/examples/widgets/dialogs/findfiles/window.h → tests/manual/findfiles/window.h
-Original file line number
+Diff line change
@@ Expand Up / @@ -215,7 +215,7 @@ void QProgressDialogPrivate::_q_disconnectOnClose() @@
       \image fusion-progressdialog.png A progress dialog shown in the Fusion widget style.
-      \sa QDialog, QProgressBar, {Find Files Example}, {Pixelator Example}
+      \sa QDialog, QProgressBar, {Pixelator Example}
     */
@@ Expand Down @@