From 3fe0bf6e1bd3713543a5b763d3bfcee0c03faf4c Mon Sep 17 00:00:00 2001 From: Volker Hilsheimer Date: Wed, 8 Feb 2023 09:41:33 +0100 Subject: [PATCH] Move findfiles example into manual tests The example follows bad and outdated practices: - running time consuming and I/O heavy workload in the GUI thread - calling processEvents to keep the UI responsive - showing results only at the end of a search rather than continuously Perhaps this example can be rewritten at some point to apply modern practices (at least use a thread and emit signals), but it seems to have low overall educational value. Moving it to be a manual test for now. Fixes: QTBUG-111002 Pick-to: 6.5 Change-Id: Id630fd4599096448ea4f96bcbf977b11a039796f Reviewed-by: Axel Spoerl Reviewed-by: Qt CI Bot --- doc/src/images/findfiles-example.png | Bin 11174 -> 0 bytes examples/widgets/dialogs/CMakeLists.txt | 1 - examples/widgets/dialogs/dialogs.pro | 1 - src/widgets/dialogs/qprogressdialog.cpp | 2 +- .../manual}/findfiles/CMakeLists.txt | 0 .../manual}/findfiles/findfiles.pro | 0 .../manual/findfiles}/findfiles.qdoc | 0 .../dialogs => tests/manual}/findfiles/main.cpp | 0 .../manual}/findfiles/window.cpp | 0 .../dialogs => tests/manual}/findfiles/window.h | 0 10 files changed, 1 insertion(+), 3 deletions(-) delete mode 100644 doc/src/images/findfiles-example.png rename {examples/widgets/dialogs => tests/manual}/findfiles/CMakeLists.txt (100%) rename {examples/widgets/dialogs => tests/manual}/findfiles/findfiles.pro (100%) rename {examples/widgets/doc/src => tests/manual/findfiles}/findfiles.qdoc (100%) rename {examples/widgets/dialogs => tests/manual}/findfiles/main.cpp (100%) rename {examples/widgets/dialogs => tests/manual}/findfiles/window.cpp (100%) rename {examples/widgets/dialogs => tests/manual}/findfiles/window.h (100%) diff --git a/doc/src/images/findfiles-example.png b/doc/src/images/findfiles-example.png deleted file mode 100644 index cf3885c015348cdaf886fa186a9b9b2db4535375..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 11174 zcmbVybyQSe^zRT#iTI@yP(oqongNj%0R?2}l2&1cmhKekjvE_M%_ul%w-+FJYw|?vWbIz{2@44rG_T6{yb;8tCHXJM!6B2@#cJ`u2cJA&DcGrj6H~-?(!59hfXiRFa z?(T-R_A8h72_?Q;JtLsE?d|ho6^rbqyDvrzAOIyy+?@^nl)ksW|L0(L0`ESH3k$)) zdKZILTU2cP_Q3(=$BtJ0M^uD(S{18D)5+b=%=kP2^4~rJ z&YWC1Uw{`~2kWbk#I}3`j-zE_G6X zkYVofZtU<(v+;0iwD_5j?p%@Pe7eZiV0?aTTpI@atrn{iT(;BWuP4g#)(M%OozoDh z+kASPgc?8G#R_V97r|pW?s2{Uz9jHD`ME}9`WLyhcVy-xS5-ZO=R=;Ke;xm9=-isB z>T0dr848^%cPnn2`ViOk?49Mx@tN%xJES!qRDtzsWt#gN#$f!qh_sm2Wzf-fke`8`?+!$Oc9=-BjPAO2I|LpF#JXK|8aFih3#)9c<4303PT+Q*O6i%}KX8Oz(h zzxo85*=TTSd~CW;6pr5mYJsx;+Qv-QP8UadZ?9>e46_#!%8>wr@gtSpx}A{lUiwRP;chf?fu%x z`tr`W_2%w~=_fNln)oNH+A_i5JAAeRKChI`4?M)#QJtSHQSuea)#|Ag(Z1yVfZJ%n z5%XHQ1Id>J^ZjA~JTWhV7^bTokTNPa;h}V>%56823*|HTgWysA^Kq$cg!WE~KSxFf zQZ>TM8IbF~EXCWkO2G_SPcb3e0tAv=3d<5PN2q-zTH}$K^Yfi)v!AhU5>9k#^mEfm5TT%d$-MSnr zo>}JsCt}wbX=w*oGriTBW&!oYP<%>tAoD-}y=e;SipLyjge3A8fRiZ5A^he3Uz4pN zY}SIPZJdRp5aX^-gpU8mKD4_NZfPOy0m4@aP65qW;wW#GT@ES>(_&0p3w^m7R4Bw=EeDaSPS2HO3uL@yiha-;>HOK))qU7 zPD`-9NM$%pUPsOeXrSL%@?;^Y-fimq&C$cXL4VL;A2j;1%FI0nGn%8k!p`(`?#Ep) z*~qv=LyN=UP$;{L#Y*`o=anha-81LIbovUEaMr<70;Zir|(Ff_%E$Dfb*3za|V<@+)wM|s5 z%cYlyw1``2=$??5l{B4TQ>T#9r`skBi-CM}Mc?enrM3GiG^0y^4qvi;kD^{v?K{?@a2I<)Uu5iBHS}Sy1mm#je5v!msUI zoIG66f92J!1o)@*=X8{yQiM(E&vETs?XWnrA8!J`!)1d0JYk)9X&w7wCEP)USTK6l z>`#mEAJ4C!dVH8xE?*D8dZ)2_`iwLCBaw;&FN}BGPN(K}DB2D|oY(=wll-~_@%Iyj)6uLl|d=f^0~Ttrt{+OVLb z(xh(&f&ggztq;;CuRVa1YMTVGpyl|e-xD7|?C3xYz`6D#fZ`MXgC>0R{9mW;V}#OA z%0xfcT$1FkWC!PC({e4y2Y=S-=^;22+K#r2J3?)Jl)v z?W0G@p{6p&;sc9j40K>^J_WC!yE1SRXqaN!2>mx4{f4etzUO=q*By02Njx< zs_(&R9iLiOe6Xq?7l?kb1pa<4UhJkZ$#A6 zEhoT_OZAeaB*MeisMZH+O+eg2(6QK;VJsR~m@aPip$V;CH=n zJ)wMZtEf9UHZ)-xYx$6)*Oc|GJphQs$nI3_&x>pZG#;iS*_iIhXMxHyOq>Rn z!7e~v<1l^pXjca6<?u6E!g5h)XFR#xVx6uzEyXQY4 zu6iYQ<`ehX(D{^|PuZDj286Xi2A&AKHzWEYOd;Kfk4KQ%^oI{gK!f8lp;6dD@7Y$z6MMG6(;bj=5M-cP;a~c$BwB^OvW} zBJRQrPye{AKrGBX1Y(&uU=aiOGvh^MOm zhJwp`W!(+@Vd_GJ3~{|K;arhntj z``^G;1NuM8!CfnZ0LTP_@B)d;QUNI~4{f6u%71-af`?%(A4$E~9{j1VEy#d#SyKH_ zIRq1owFFr68cipPFr9+`mD$Q?rQLkRNoUP-A?3os6FEf~Qoq<O5;c688v@>9I7iwlg+vNJIv`xcOYFdt zW%`TQx@6UUX-UC52QyS@!QTEvC^tL0*%_`>eb2pz;Yb)5u!7!?+`3#mL#I& z^W-L+dX-<(l`)L$3jgk|g?EPiCCHa2#O5J1h6%ytw1Rtlws*K*o(dw=>9X&Rc$3WDW9!j=s@c5-s z_ohbChMmf}6qvm1#P;Q;t=-n=zMREgWGk3-YV>Kf7JE3P@b~pb8dfiV$gP1uRjT_K z{}H^X#Z0~wgDwu4>dURp1VCPVEcfz zv;co7IGdM3HIV<&jZ6_V8a9Hfu7n zFtDZ4jY&W`@Y9p-vM^oqjC$_?gSLA=$vElt+l_QPgF;_~lhM$0($L(?>uNp=?V^hU z@BMV3NLP303KOSafe5uMXmhzZ*cN17UZ+ZLW+?F7c~6M{x#w0WE1qOIz2;`Nl1eY} zMm;jpm_7W5cvR|ij=^k|GQU?Bn{KhBaPJ3gR>isH-y{kByG|9D4AiByf*N2>RTn7P z7TQ9C{aKx?xE=d0GmUfq%{KJz0Cvjjy(RTq>r{O*NzQ9KaliL^3_b_hd7 zR7r^#@M%6-u%$`tm1Qkxge;lIwbt=uDO-J|k+sA=)Od2(7VzX%Q+q55a#6Tg>bP9Jw`0% zXC>E*wYbK3R%u%z;8V5GE-|=X;Wd?=-TtClORyMxsi0g`Gh=aFQs41fNmo@(Zxl&PcwgIuEy*I+8A!)6Ap~0okAoul_ zyHhdd0GJo>4E>-?TXOPctt*VL9<$YH$?o}!;ZdLOx=Xzu^HaI!}J<;>|;6aNijXd>(C!kc%* z?QEAo%l#XWzadz-&W-bcwSa7K{=qcQ@MC??48+-nTwl)GYVLPTIOp|)N2>Pb&fT}v zR^2-BRU0D(&l38Q;p^p0Me2Xsf(5MdFNP~t@`ccSe;&)911xY`MnpNDJQ`@1{-!WU zIHGiGB1E_W6b$pHnK+RA69lKI)%F|<4 z-3mwM{{SABT77StD|gl-Ona@+GW^+SWZfD;a{XEL`$vV;PZ@MVLl8fber$&wPeR-$ zk$`GPgof$u&x^>tl4y~j!L2D&FzYV8(n2Z)t0kk4_-jccLADCBB7Lp35*o=)--kq?YXJY(YmcF@dw@M19SRNw)Wx|LwK_GMA}*;HbAiSAHLvB5p;+8&yHfVmz7YTQO1?fNdt zt+U`ErKaB4R?cZuF_7O>ZiMh=X<8lL*M*sDAgF=8-$2@5(bv*1y-T3GF(7S4Jwz{O z$(2g+7<9fsy#yVcGk_g_SSb2<_H<6u1M&R3@@Z)C|_h=kETw!e9?7RLg6& zDYW<5@#X_s@lfRKLnUDb)87wrAY&C7c$KHB+)mTLZOi?)LoIU#D7@t@cWyr&hPgen zs5lXoT%s47D*QSVSFYYR=Ko0eqqRPsyaSuEGai7h4nEbCv}hH()oRX@@l+Syj)STf zNov5-zdqBufpo}o*WRDN(m4asqc5$#@0ZQFBub6PkdcOx=2*TYs4nn4D;bJ)7=OZR zCdH}t1G3WBXOWZ7UYxJvwh;dWX=DX6TwR`y6uqA1L0=zjSkwe3;R4(9g=(h6On@y^ zBkp$mj5~D_J*tkt+CupXGx&lm-{4UsD$*-|K3N65Acz#y=R(bpdS<$cOu%@un0nLh zLvI}xlBV2WrS)d@bXY=91=w8+&!VA8rg;I?+5X+=2dy6O3uhPy?jL}-k>#?-Johg& zvq&#EjlnL9ByY5k(FdT-9@qU&R&ZL@rSnsMO>+bA3ID>oNiZfh(aR!nesK;_;0o$@Qd{Ve$-GS@%C{?ckZb64=K+AyabqQ|_L?C`JxePHp`CK!(*H=ge+` zkOLmsW_JugK7jTm7cYKL@xfW#ncz~T-djvUSs$R$86s|bo4fdeo zO^hhub*^qE{1p(rBBPW>XUeV;B4&ilG2B@y&nI(Q1^pnz&;Z)*1wTv@PI!hkq?a62 z;xK|KE)IoMXr}X_6lPMT0&@HxqY3Sm&a0pE;&RXL)`l2nc&UiiqvG=cml}-KizkH( z=sx)4d2}b2O?r;WLieEc@$XPm)IES&R}NVqjI}&U3wdLaB$eHg;90t* z-O>yI@FmuZH1M?YxAxEe6%z)I-hhUY&rNxokk4KAa-}V5v8AKG$KX%cU~njK=EI()LSnie|MUD?@WMyjEdpXn3z)@Vz2%K(1=#J>q$K9 zgSjW0U3z=)Zu=0AKh=Yk)=2HDWKOyJLML$pSRl{-w=4^ybIkm+CLy|Rho>gj9Auot z*wH61@@3Unz7oE$a`!kG5@@JOQwk?0OmuXj*v=oM%&8B_$%}X&Yuv!I6-yx_?oyOM zYvh@opdfemW?&`3+BkpR!`_EtKUu(=Z+_l8)4c8`KNlkX98Jjj|1;&rLS0Ry2Bu{F zS6Y*%j!Nvx;n@)BNxhFRUQdrtL8KS;KF(tC@dxl5L81rSoxAP(MsXXBg+4K5xbEZ< zPr2#euW?xs{2|vq#`wd%*#CG=l)*K9Tp8&dq1DJq5R>fHdpjctLU5)OP>>v zd5s5Gbke)hPO8^pG+WR+e$E+d2!}%2C%dd19GMX!pZgmUw%BH;8u3)53KMBbE2R%7A>?r?w%`sqO5Z$3UQA*15yn1h;#CwU-fqnVKJJhIfTIwdpNk!a%=x0C~BWkWZf00%oR1l_qXdZF5 z+FnuIl}Sa-VTD#u75;n~TNu#X{qdelD(LGX6n6O5s}{4P!!-&kw)s2*DSe_}V9|)^6ybxz8-4fc{$ETXjuTR8JK5ARpq$TutsN5o-Bb6w; zAxF*5IKX7!TIJ?Az`VxY?gj^o z{~{au->jCo`Tfgt@)NR_oErRtWHE3Zkbc1|4w5akHm*I?Vg&!S!uXlP$;&EeHKNY2 zbi1}BReWS8(|2O&c?QX7H{=~f=>;F6ksbRIUN+P3t7~jNK0b@cV1IB3!s5Fy+~yyB zw@VN$>z20Te0h{edOE3LZ65r1vy>cbd0l7jd>y3gB2_CfO*z!N)5=A;uh(pBwE>FMmb*6j5;{PrIy7 zKWH5qJ?iNlc*~8LKDo6utD#9V6lCw2V@M&4Lj^+E7P>}v)UfhY3BP#Ev*aFSy=@5U2)MPuueh%Z@J+*zC0rK_ z^!uz$@s}YD7TjRGy^-Vw^gE&x^#g{j_MthgPJG&5!snXZIuwz1RZ4yKtt8i$sdJh1 zriq198lj|NCN8ku-kl>`5ZG0g4N=d@FYdZC*{cTd&BBO~=XeVvltT_(Two<0A3ai^ zjftygz!(~UI>Co3pfupK8fyR7>?6canLg^qTLNV-8pKdOl@q1UC>XDzG~@EvXTH>^ zBKuqYyza_r7!2JnFEqLyN{~u6I-LSH34I;CtXfwh+-CpkWSQS5GMO`M8IYhI%G%n5 za9@{?Rqs|V2)ONs@eQgfGxE7r+X%pYLqTFvw+TPLFwJaOi4F*nUH2Gna)qgu0X2nB zo-VoErWuvH0ryh@8h=Yk{u6Nj1zi8)@4v;W-!!(pQX%{v-$M4l|F_Xc0P7w;0ki4j z$%d|&{-PvUO*TdSs0qQNax%=yp3${;(S#*9ZEC89UnUX%x$9St*%#zK9usN1se=a8 z!#4EztULHl@s=+ir0BgzqFws90e8NSKd>QI(7nfT5b581<%dGz9(vH!XKnQE(j9yP zF^$$0yBZvJuo3YSm2$lu00GW}!MgF_wDpWqAEwJ7kC&l=1Ay=PRdl2TmW0#;$jl3~ zApC)UjHu#Cv<4AvcQIgcK-jAhKx}9~E?40~eFGQjVz}7*uj~=G*V+EG+*4`1CfU!= z@8!v6Kcsmo$8w*Lq=EXGvm=etkh1QOvRLT1Z?d#R?RRe;iI0xGQM0#qu(xP*-q07T zflnMaIu|r6sgMt5iR%xP6QiQsgeW-U8+_FKktOf{ewg;d zg3}?hJsAYV;_yF*5SgHFU83dWPD z8+?o>3Hx`5`%kLg;G^`CG1aR+XCUh^B38j%2KONd`)@KTPGlt$2u8f&nl@G{{F=5e z&0g+$AQszyS7wh>aqg?|xYbBGoBQ6SdtaTkm~|Y~w$Ymy&o*Awoo#h@WTo-@@!qDn z^CBLV-_z-b{SZO+ML15LFfg(G>+Uo`^wrMQ#92HE-v3&!ZkYn`kL}l}*B)ZxegcRX z#uCglOTZ_)ugX}LR$E4ewew-Ki|2soihD1&jH!CS|1su)S%wO%J3A%gN$9%xgy^GS zD7~_YncW&Qncz9I%(8e76%b3HnauOvKsh!B4Dau8_&nWhlFIggk7w@LRCxPAh-rs1S1zT2%gU-v!AQL&F%RFkwh5u zk0lg(%6i#fPcb*1L2(*VeKf;#wl{yZ>-)HWKYc$F++iP>qR9L}J`_RtU&+BC_ulki zT~fgWX?s$7><9MTp+{g6Li0u8@gnzs{-u~1R<+E2L-5;0VbL!0Avh3O!WC_S{t zckX?4!p8&{_~miV{?N03>aXV5WS*va*qf91Y-ErKSM56YuS%B=&2i>vYl|^3ya&f$ zG}i@w@Etg)3hbXC$6yWvWq<)lOKtPCph{U|TKeHEghy7OCi*}@R9Foiv$-_%VLgQt z_=zL6IGeaM2xAmJmuC6!FSZg7;MV9Aq{Shv1~TI9+-ab_?gv`8QL{J3NS%jlHsssKykA19xOC`jC0T;*b1 zTw$g9Ez$H6v4j%g_^zi=O~MJ8H7WgoxwOWnuQx-ImO9;W2o1qu7{22uMz>VBlWj*> z9bXCD=1=~0+;nY7({kBY%#Na}zvHV8ia8<7dKhArzb&b=uyr)-yJ>cc#cCL8>jIBP1zVXGthUPD;eRs^WKKeEX|5 z%7NQ873=eXMWqs5{Ej_zC-9hVjCwck_h=zIt|ctwHO+4k%lAfPrlrcUO^|9M3Xx^Z z11Zg1v71O$iqoiFmnn>ey~#x&PEyh3PiPTE^Z4wKZODFqF6}pQybTKy8Bv2zt?_!@#~V`o zE7s!W|G>ab4-P(TWS2xQKFqulZK+RW7=e?0ad(Fw!i*<%9a@KpVs5vFSIgLmNQYi^ zpF(LuxPN^~sZ8Z+N;7bxkzw5Yq^(5X;Xo1-Pt13?oq}0z30~CbnY|PNyNXoZiCNrz zacB{Cp&@qj_(bMYa0L_Wd7*`3_W&ztx|}zIJcUOC9l{K;eblSZ=g!@J z7T~?1{!mvtfw3(&q9bVtAs*woCAR_k5zH`aVLL7!JOhFGSkn6Nd-@DR_IlEKm8IUa zg(f{HWfIJ8R4b6OMAKQT@h6NIM(c!**)W;|(fCY{iuD9jw+Ue=dsZpJm>G{g(jW=7 zll~HaLQ(KVw{-m@LsEIzu(Sp7OQ%ylkyZ3haoP*cSy#CSQxF$*j&;T_RyD8=8?MjA zw5?M`Wt$Wk0xYU+pV}e!Dg7JxIlIu9jf3hgL^%!C20_IUjer)3%`n>l;gyy>;o2~I zVg=fTO*wEoupgtMT_Vu_E%@DC;0K$vdkVz=co!~)%n$TKRv`5M{33;g56yb(2yc-l zvCBT(Ffe1xBJwQ@&i{!$4q>4Dca5%5XQz9UY$+a;5-B7zIcdFBM6)XlQuOP8YG8cf zWlD;Q2pjwn$l~ZXku`du)ArSyG{ooxhPN43Y{01hG!?P#MEJ!si$-2*2qV#sSs`$Rk6GiL#$h#c z4{Ch}%w`C-vM$PON+zxw$V?eW8_^4|2eR-qBf;jVW|(7ws4ojdPTEISHN^r+0@Lk( z+4dmzJnz~QHp%FEZ%Y3{d~lW0a$Y7%=82xve(A> zB4R_L5Q7GzUPPZ!|31;kR|L`+tlR@pExq}M(0FxSh!-Uderfk!OWTc;8+`Li+ez<( zu(}H^nzO3Z@t^?_EKKwyzPQL3T;wEP&qlhca)T^hHU|Ht?9>&|tb^ZCs0EGl5o0i4 zg=1Fqxz7LbQ6l4JbMEKv_f-Js2&nNf-!qmK4b)YRb z_jjAMWkDb6*F-;CVEw(cxq`uk8!>7;i8SMuT|^fWHdrm%?IRbA^C3I4uBkmN`uDD% z0PG=S8lp$TV*MMTR?LMt?V7sq4F90p4VXgid}RJvp3oyXhbIG6<{y$pf~@b?Dln9j z6IL7$;?DOGe6aqs+UZE<#X#|KACD(pLE&*v2lbtDi;3_q?E>vl3PK;+70#7de}3sP z#izRsvU+NDYIN!^znl#+v3p{kN#6?+$?KTgnhS39@p7+pc$JSCYq&15*B9zDyq=$V z?dRQsT7ofUy`(I_m|i{|bz~f2oG`HT@9DM7)n21R@P6e=a;mlR z?pGf4U)&~9GFAnQsspn_L3nTBBpkTr49+^7gGvo|JPX&Yp~k7c!>1Skf2Ke zv#Q-HIGy8RX(K*!&bGv=y&wro_aEQ;(*9oIqJgksxR4Ve^K-inn_B=azAdEmYONc0 Q{uZG4Rz