Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Validation for API URL #471

Open
sauravpanda opened this issue Aug 21, 2024 · 4 comments
Open

Input Validation for API URL #471

sauravpanda opened this issue Aug 21, 2024 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest 2024 hacktoberfest-accepted Accepted for hacktoberfest! High Security

Comments

@sauravpanda
Copy link
Member

Issue Details

Severity: High
Category: Security
File Path: https://github.com/Cloud-Code-AI/kaizen/blob/main//kaizen/tests/actions/diff_pr_test.py?plain=1#L18

Description

Potential for URL manipulation leading to API abuse.

Impact

If user inputs are not validated, it could lead to unauthorized access or data leakage through crafted URLs.

Suggestion

Validate and sanitize inputs for owner, repo, and pr_number before using them in the URL.

Code Sample
NA
Proposed Solution
Use regex or a validation library to ensure inputs conform to expected formats.

✨ Generated with love by Kaizen ❤️

@ameeetgaikwad
Copy link

ameeetgaikwad commented Aug 24, 2024

@sauravpanda would like to take this one!

should Pydantic be used ?

@sauravpanda
Copy link
Member Author

sure, go ahead, pydantic would be nice!

@Kaos599
Copy link
Contributor

Kaos599 commented Oct 29, 2024

@sauravpanda i have tried working on this issue with a PR.
Can you take a look? and if possible assign his issue with a hacktoberfest label

@sauravpanda sauravpanda added hacktoberfest Hacktoberfest 2024 hacktoberfest-accepted Accepted for hacktoberfest! labels Oct 30, 2024
@sauravpanda
Copy link
Member Author

Sure, thanks for contributing, just updated the labels, let me know if I am missing something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest 2024 hacktoberfest-accepted Accepted for hacktoberfest! High Security
Projects
None yet
Development

No branches or pull requests

3 participants