Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SpeechSide= no longer works #108

Closed
Bittah opened this issue May 24, 2024 · 1 comment
Closed

Bug: SpeechSide= no longer works #108

Bittah opened this issue May 24, 2024 · 1 comment

Comments

@Bittah
Copy link
Member

Bittah commented May 24, 2024

SpeechSide= under [Basic] in mission maps no longer works and this specifically appears to be caused by certain code that's present in all mod specific hack files ( ts_hacks.asm, dta_hacks.asm, ti_hacks.asm, to_hacks.asm, rubicon_hacks.asm, fd_hacks.asm, tm_hacks.asm):

; Load speech MIX files for new sides properly
@SET 0x005DD822, {xor ecx, ecx}
@CLEAR 0x005DD824, 0x90, 0x005DD828
@SET 0x005DD82B, {mov cl, byte [0x007E2500]} ; Compile warning: byte value exceeds bounds?
@Bittah
Copy link
Member Author

Bittah commented May 25, 2024

Fixed by 28bd831.

@Bittah Bittah closed this as completed May 25, 2024
Bittah added a commit to CnCNet/cncnet-ts-client-package that referenced this issue May 25, 2024
Bittah added a commit to CnCNet/cncnet-ts-client-package that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant