Skip to content

Commit

Permalink
Fixed workaround for bug in JaQue library
Browse files Browse the repository at this point in the history
  • Loading branch information
CollinAlpert committed Aug 11, 2018
1 parent 0d63e50 commit 9db11cb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
7 changes: 5 additions & 2 deletions src/main/java/lambda2sql/ToSqlVisitor.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
import com.trigersoft.jaque.expression.*;

import java.util.ArrayList;
import java.util.List;

import static com.trigersoft.jaque.expression.ExpressionType.*;

public class ToSqlVisitor implements ExpressionVisitor<StringBuilder> {

private StringBuilder sb = new StringBuilder();
private Expression body;
private ArrayList<ConstantExpression> parameters = new ArrayList<>();
private List<ConstantExpression> parameters = new ArrayList<>();

private static String toSqlOp(int expressionType) {
switch (expressionType) {
Expand All @@ -20,6 +21,8 @@ private static String toSqlOp(int expressionType) {
return "AND";
case LogicalOr:
return "OR";
case Convert:
return "";
}
return ExpressionType.toString(expressionType);
}
Expand Down Expand Up @@ -76,7 +79,7 @@ public StringBuilder visit(ParameterExpression e) {

@Override
public StringBuilder visit(UnaryExpression e) {
sb.append(ExpressionType.toString(e.getExpressionType()));
sb.append(toSqlOp(e.getExpressionType()));
return e.getFirst().accept(this);
}

Expand Down
5 changes: 4 additions & 1 deletion src/test/java/lambda2sql/Lambda2SqlTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ public void testMultipleLogicalOps() {
@Test
public void testWithVariables() {
String name = "Donald";
assertEqual("name = 'Donald'", person -> person.getName() == name);
//Datatype must be "Integer" for now. This is due to a bug in the JaQue library and author has been notified.
//As soon as the bug is fixed, the test will be updated.
Integer age = 80;
assertEqual("name = 'Donald' AND age > 80", person -> person.getName() == name && person.getAge() > age);
}

private void assertEqual(String expectedSql, SqlPredicate<Person> p) {
Expand Down

0 comments on commit 9db11cb

Please sign in to comment.