Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Pipeline status stopped in a configuration file still runs the pipeline #2061

Open
raulb opened this issue Jan 9, 2025 · 2 comments
Open
Labels
bug Something isn't working

Comments

@raulb
Copy link
Member

raulb commented Jan 9, 2025

Bug description

This pipeline with the status stopped shouldn't run:

version: "2.2"
pipelines:
  - id: example-pipeline
    status: stopped
    name: "test"
    connectors:
      - id: example-source
        type: source
        plugin: "generator"
        settings:
          # Generate field 'airline' of type string
          # Type: string
          # Optional
          format.options.airline: 'string'
          # Generate field 'scheduledDeparture' of type 'time'
          # Type: string
          # Optional
          format.options.scheduledDeparture: 'time'
          # The format of the generated payload data (raw, structured, file).
          # Type: string
          # Optional
          format.type: 'structured'
          # The maximum rate in records per second, at which records are
          # generated (0 means no rate limit).
          # Type: float
          # Optional
          rate: '1'
      - id: example-destination
        type: destination
        plugin: "file"
        settings:
          # Path is the file path used by the connector to read/write records.
          # Type: string
          # Optional
          path: './destination.txt'

This used to work so it seems there's been a regression.

Steps to reproduce

  1. Use the configuration pipeline that's above.
  2. Run conduit $ conduit run
  3. Notice this pipeline runs (it shouldn't).

Version

v0.13.0-nightly.20250109

@raulb raulb added bug Something isn't working triage Needs to be triaged labels Jan 9, 2025
@github-project-automation github-project-automation bot moved this to Triage in Conduit Main Jan 9, 2025
@hariso
Copy link
Contributor

hariso commented Jan 13, 2025

@raulb I just tried it out both on the version you provided and on main (a3aa0c4), but it works as expected. I built Conduit myself and also used a GitHub release.

@lovromazgon
Copy link
Member

If I'm not mistaken, it only happens if you first have status: running and then change it to status: stopped.

@simonl2002 simonl2002 removed the triage Needs to be triaged label Jan 13, 2025
@simonl2002 simonl2002 moved this to Todo in Conduit Roadmap Jan 13, 2025
@simonl2002 simonl2002 removed the status in Conduit Main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Status: Todo
Development

No branches or pull requests

4 participants