forked from JuliaLang/julia
-
Notifications
You must be signed in to change notification settings - Fork 0
/
irpasses.jl
456 lines (419 loc) · 12.8 KB
/
irpasses.jl
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
# This file is a part of Julia. License is MIT: https://julialang.org/license
using Test
using Base.Meta
using Core: PhiNode, SSAValue, GotoNode, PiNode, QuoteNode, ReturnNode, GotoIfNot
# Tests for domsort
## Test that domsort doesn't mangle single-argument phis (#29262)
let m = Meta.@lower 1 + 1
@assert Meta.isexpr(m, :thunk)
src = m.args[1]::Core.CodeInfo
src.code = Any[
# block 1
Expr(:call, :opaque),
GotoIfNot(Core.SSAValue(1), 10),
# block 2
Core.PhiNode(Int32[8], Any[Core.SSAValue(7)]), # <- This phi must not get replaced by %7
Core.PhiNode(Int32[2, 8], Any[true, false]),
GotoIfNot(Core.SSAValue(1), 7),
# block 3
Expr(:call, :+, Core.SSAValue(3), 1),
# block 4
Core.PhiNode(Int32[5, 6], Any[0, Core.SSAValue(6)]),
Expr(:call, >, Core.SSAValue(7), 10),
GotoIfNot(Core.SSAValue(8), 3),
# block 5
Core.PhiNode(Int32[2, 8], Any[0, Core.SSAValue(7)]),
ReturnNode(Core.SSAValue(10)),
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.codelocs = fill(Int32(1), nstmts)
src.ssaflags = fill(Int32(0), nstmts)
ir = Core.Compiler.inflate_ir(src)
Core.Compiler.verify_ir(ir)
domtree = Core.Compiler.construct_domtree(ir.cfg.blocks)
ir = Core.Compiler.domsort_ssa!(ir, domtree)
Core.Compiler.verify_ir(ir)
phi = ir.stmts.inst[3]
@test isa(phi, Core.PhiNode) && length(phi.edges) == 1
end
# test that we don't stack-overflow in SNCA with large functions.
let m = Meta.@lower 1 + 1
@assert Meta.isexpr(m, :thunk)
src = m.args[1]::Core.CodeInfo
code = Any[]
N = 2^15
for i in 1:2:N
push!(code, Expr(:call, :opaque))
push!(code, GotoIfNot(Core.SSAValue(i), N+2)) # skip one block
end
# all goto here
push!(code, Expr(:call, :opaque))
push!(code, ReturnNode(nothing))
src.code = code
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.codelocs = fill(Int32(1), nstmts)
src.ssaflags = fill(Int32(0), nstmts)
ir = Core.Compiler.inflate_ir(src)
Core.Compiler.verify_ir(ir)
domtree = Core.Compiler.construct_domtree(ir.cfg.blocks)
ir = Core.Compiler.domsort_ssa!(ir, domtree)
Core.Compiler.verify_ir(ir)
end
# Tests for SROA
mutable struct Foo30594; x::Float64; end
Base.copy(x::Foo30594) = Foo30594(x.x)
function add!(p::Foo30594, off::Foo30594)
p.x += off.x
return p
end
Base.:(+)(a::Foo30594, b::Foo30594) = add!(copy(a), b)
let results = Float64[]
@noinline use30594(x) = push!(results, x.x); nothing
function foo30594(cnt::Int, dx::Int)
step = Foo30594(dx)
curr = step + Foo30594(1)
for i in 1:cnt
use30594(curr)
curr = curr + step
end
nothing
end
foo30594(4, -1)
@test results == [0.0, -1.0, -2.0, -3.0]
end
# Issue #29983
# This one is a bit hard to trigger, but the key is to create a case
# where SROA needs to introduce an intermediate type-unstable phi node
struct Foo29983{T}
x::Tuple{T}
end
struct Bar29983{S}
x::S
end
Base.:+(a::T, b::Bar29983{S}) where {T, S} = Bar29983(a + b.x)
Base.:+(a::Bar29983{S}, b::T) where {T, S} = b + a
Base.:+(a::Bar29983{S}, b::Bar29983{T}) where {T, S} = Bar29983(a.x + b.x)
Base.:+(a::Foo29983, b::Foo29983) = Foo29983((a.x[1] + b.x[1],))
function f(x::Vector{T}) where {T}
x1 = Foo29983((x[1],))
la1 = Foo29983((x[1],))
f1 = Foo29983((0,))
for _ in 1:2
f1 += la1
end
return f1
end
@test f([Bar29983(1.0)]).x[1].x == 2.0
# Issue #31139 - Checking for correct number of arguments in getfield elim
let nt = (a=1, b=2)
blah31139(x) = getfield(x)
# Shouldn't throw
@test isa(code_typed(blah31139, Tuple{typeof(nt)}), Array)
# Should throw
@test_throws ArgumentError blah31139(nt)
end
# Expr(:new) annotated as PartialStruct
struct FooPartial
x
y
global f_partial
f_partial(x) = new(x, 2).x
end
let ci = code_typed(f_partial, Tuple{Float64})[1].first
@test length(ci.code) == 1 && isa(ci.code[1], ReturnNode)
end
# A SSAValue after the compaction line
let m = Meta.@lower 1 + 1
@assert Meta.isexpr(m, :thunk)
src = m.args[1]::Core.CodeInfo
src.code = Any[
# block 1
nothing,
# block 2
PhiNode(Int32[1, 7], Any[Core.Argument(2), SSAValue(9)]),
Expr(:call, isa, SSAValue(2), UnionAll),
GotoIfNot(Core.SSAValue(3), 11),
# block 3
nothing,
nothing,
PiNode(SSAValue(2), UnionAll),
Expr(:call, getfield, SSAValue(7), QuoteNode(:body)),
SSAValue(8), # <-- This SSAValue is the problem.
# SROA needs to propagate the old taint when it follows
# the phinode here
GotoNode(2),
# block 5
ReturnNode(Core.SSAValue(2)),
]
src.ssavaluetypes = Any[
Nothing,
Any,
Bool,
Any,
Nothing,
Nothing,
UnionAll,
Any,
Any,
Any,
Any
]
nstmts = length(src.code)
src.codelocs = fill(Int32(1), nstmts)
src.ssaflags = fill(Int32(0), nstmts)
ir = Core.Compiler.inflate_ir(src, Any[], Any[Any, Any])
@test Core.Compiler.verify_ir(ir) === nothing
ir = @test_nowarn Core.Compiler.getfield_elim_pass!(ir)
@test Core.Compiler.verify_ir(ir) === nothing
end
# Issue #31546 - missing widenconst in SROA
function f_31546(x)
(a, b) = x == "r" ? (false, false) :
x == "r+" ? (true, false) :
x == "w" ? (true, true) : error()
return a, b
end
@test f_31546("w") == (true, true)
# Tests for cfg simplification
let src = code_typed(gcd, Tuple{Int, Int})[1].first
# Test that cfg_simplify doesn't mangle IR on code with loops
ir = Core.Compiler.inflate_ir(src)
Core.Compiler.verify_ir(ir)
ir = Core.Compiler.cfg_simplify!(ir)
Core.Compiler.verify_ir(ir)
end
let m = Meta.@lower 1 + 1
# Test that CFG simplify combines redundant basic blocks
@assert Meta.isexpr(m, :thunk)
src = m.args[1]::Core.CodeInfo
src.code = Any[
Core.Compiler.GotoNode(2),
Core.Compiler.GotoNode(3),
Core.Compiler.GotoNode(4),
Core.Compiler.GotoNode(5),
Core.Compiler.GotoNode(6),
Core.Compiler.GotoNode(7),
ReturnNode(2)
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.codelocs = fill(Int32(1), nstmts)
src.ssaflags = fill(Int32(0), nstmts)
ir = Core.Compiler.inflate_ir(src)
Core.Compiler.verify_ir(ir)
ir = Core.Compiler.cfg_simplify!(ir)
Core.Compiler.verify_ir(ir)
ir = Core.Compiler.compact!(ir)
@test length(ir.cfg.blocks) == 1 && Core.Compiler.length(ir.stmts) == 1
end
let m = Meta.@lower 1 + 1
# Test that CFG simplify doesn't mess up when chaining past return blocks
@assert Meta.isexpr(m, :thunk)
src = m.args[1]::Core.CodeInfo
src.code = Any[
Core.Compiler.GotoIfNot(Core.Compiler.Argument(2), 3),
Core.Compiler.GotoNode(4),
ReturnNode(1),
Core.Compiler.GotoNode(5),
Core.Compiler.GotoIfNot(Core.Compiler.Argument(2), 7),
# This fall through block of the previous GotoIfNot
# must be moved up along with it, when we merge it
# into the goto 4 block.
ReturnNode(2),
ReturnNode(3)
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.codelocs = fill(Int32(1), nstmts)
src.ssaflags = fill(Int32(0), nstmts)
ir = Core.Compiler.inflate_ir(src)
Core.Compiler.verify_ir(ir)
ir = Core.Compiler.cfg_simplify!(ir)
Core.Compiler.verify_ir(ir)
@test length(ir.cfg.blocks) == 5
ret_2 = ir.stmts.inst[ir.cfg.blocks[3].stmts[end]]
@test isa(ret_2, Core.Compiler.ReturnNode) && ret_2.val == 2
end
let m = Meta.@lower 1 + 1
# Test that CFG simplify doesn't try to merge every block in a loop into
# its predecessor
@assert Meta.isexpr(m, :thunk)
src = m.args[1]::Core.CodeInfo
src.code = Any[
# Block 1
Core.Compiler.GotoNode(2),
# Block 2
Core.Compiler.GotoNode(3),
# Block 3
Core.Compiler.GotoNode(1)
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.codelocs = fill(Int32(1), nstmts)
src.ssaflags = fill(Int32(0), nstmts)
ir = Core.Compiler.inflate_ir(src)
Core.Compiler.verify_ir(ir)
ir = Core.Compiler.cfg_simplify!(ir)
Core.Compiler.verify_ir(ir)
@test length(ir.cfg.blocks) == 1
end
# Issue #29213
function f_29213()
while true
try
break
finally
end
end
while 1==1
try
ed = (_not_defined,)
finally
break
end
end
ed = string(ed)
end
@test_throws UndefVarError f_29213()
function test_29253(K)
if true
try
error()
catch e
end
end
size(K,1)
end
let K = rand(2,2)
@test test_29253(K) == 2
end
function no_op_refint(r)
r[]
return
end
let code = code_typed(no_op_refint,Tuple{Base.RefValue{Int}})[1].first.code
@test length(code) == 1
@test isa(code[1], Core.ReturnNode)
@test code[1].val === nothing
end
# check getfield elim handling of GlobalRef
const _some_coeffs = (1,[2],3,4)
splat_from_globalref(x) = (x, _some_coeffs...,)
@test splat_from_globalref(0) == (0, 1, [2], 3, 4)
function pi_on_argument(x)
if isa(x, Core.Argument)
return x.n
end
return -2
end
let code = code_typed(pi_on_argument, Tuple{Any})[1].first.code,
nisa = 0, found_pi = false
for stmt in code
if Meta.isexpr(stmt, :call)
callee = stmt.args[1]
if (callee === isa || callee === :isa || (isa(callee, GlobalRef) &&
callee.name === :isa))
nisa += 1
end
elseif stmt === Core.PiNode(Core.Argument(2), Core.Argument)
found_pi = true
end
end
@test nisa == 1
@test found_pi
end
# issue #38936
# check that getfield elim can handle unions of tuple types
mutable struct S38936{T} content::T end
struct PrintAll{T} <: Function
parts::T
end
function (f::PrintAll)(io::IO)
for x in f.parts
print(io, x)
end
end
let f = PrintAll((S38936("<span>"), "data", S38936("</span")))
@test !any(code_typed(f, (IOBuffer,))[1][1].code) do stmt
stmt isa Expr && stmt.head === :call && stmt.args[1] === GlobalRef(Core, :tuple)
end
end
exc39508 = ErrorException("expected")
@noinline function test39508()
local err
try
err = exc39508::Exception
throw(err)
false
catch ex
@test ex === err
end
return err
end
@test test39508() === exc39508
let # `getfield_elim_pass!` should work with constant globals
# immutable pass
src = @eval Module() begin
const REF_FLD = :x
struct ImmutableRef{T}
x::T
end
code_typed((Int,)) do x
r = ImmutableRef{Int}(x) # should be eliminated
x = getfield(r, REF_FLD) # should be eliminated
return sin(x)
end |> only |> first
end
@test !any(src.code) do @nospecialize(stmt)
Meta.isexpr(stmt, :call) || return false
ft = Core.Compiler.argextype(stmt.args[1], src, Any[], src.slottypes)
return Core.Compiler.widenconst(ft) == typeof(getfield)
end
@test !any(src.code) do @nospecialize(stmt)
return Meta.isexpr(stmt, :new)
end
# mutable pass
src = @eval Module() begin
const REF_FLD = :x
code_typed() do
r = Ref{Int}(42) # should be eliminated
x = getfield(r, REF_FLD) # should be eliminated
return sin(x)
end |> only |> first
end
@test !any(src.code) do @nospecialize(stmt)
Meta.isexpr(stmt, :call) || return false
ft = Core.Compiler.argextype(stmt.args[1], src, Any[], src.slottypes)
return Core.Compiler.widenconst(ft) == typeof(getfield)
end
@test !any(src.code) do @nospecialize(stmt)
return Meta.isexpr(stmt, :new)
end
end
let # `typeassert_elim_pass!`
src = @eval Module() begin
struct Foo; x; end
code_typed((Int,)) do a
x1 = Foo(a)
x2 = Foo(x1)
x3 = Foo(x2)
r1 = (x2.x::Foo).x
r2 = (x2.x::Foo).x::Int
r3 = (x2.x::Foo).x::Integer
r4 = ((x3.x::Foo).x::Foo).x
return r1, r2, r3, r4
end |> only |> first
end
# eliminate `typeassert(f2.a, Foo)`
@test all(src.code) do @nospecialize(stmt)
Meta.isexpr(stmt, :call) || return true
ft = Core.Compiler.argextype(stmt.args[1], src, Any[], src.slottypes)
return Core.Compiler.widenconst(ft) !== typeof(typeassert)
end
# succeeding simple DCE will eliminate `Foo(a)`
@test all(src.code) do @nospecialize(stmt)
return !Meta.isexpr(stmt, :new)
end
end