Please give us feedback and improvement points!

[PatrickAlphaC]

In this thread, please leave feedback on your favorite parts, and least favorite parts of the course!

This way, we can keep updating so we can make Cyfrin Updraft easier and easier for you to learn.

CURRENT FEEDBACK POINTS:

• Quizzes
• More challenges

[KeySkills]

In Advanced Foundry Course, Section 3 - Develop Defi Protocol Lesson 16: DSCEngine advanced testing and Lesson 17: Write fuzz tests and contain the same video.

[PatrickAlphaC]

Thanks! We will fix.

[HonourJAH]

Front-end and web3.js or ether.js course would be appreciated.

[EngrPips]

There is something in the pipe for front end I believe

[Aaryan-Urunkar]

First of all, a supreme effort and a mega thanks to the Cyrfin team and @PatrickAlphaC sir for creating this course! I just had a few pieces of feedback:

1. The ERC-20 token and the NFT part seemed a bit rushed, which I don't know why put me off from finishing video 2(or even touching the course) for nearly a week. I don't know if it was just me or anybody else as well, but yeah, thought of putting it down here.

2. Secondly, I had migrated to this course after watching nearly 8 hours of the Hardhat one from freecodecamp which is outdated and hence I found it difficult to follow that one. It would be VERY VERY appreciated if the team could do a similar frontend course. Even if it isn't an entire mammoth course with the new updated Hardhat but just the frontend part for some of the existing foundry projects from this course, I would appreciate it, and I think many others would too!

Thankyou again!!!

[PatrickAlphaC]

ERC-20 token and the NFT part seemed a bit rushed

Thanks for this feedback! Which parts would you have wished we went over deeper / slower so it would feel less rushed?

a similar frontend course.

This year ;)

[Aaryan-Urunkar]

The parts I feel you should have dived deeper into is definitely during the ERC20 intro section. I left that section feeling doubtful if I understood it or not but yeah, during DSC, I had to google a lot of stuff abt ERC-20 which I previously was unclear about. Hence I feel that the ERC-20 section can slightly be improved so that by DSC everyone has a better idea abt what ERC-20s are.

Very hyped up for the frontend course sir!! Already know it's gonna be a bombshell as soon as it is out! In the meanwhile, just gonna build up project from whatever I have learned so far.

EDIT: Thanks to this course I ended up with my first ever answer on stack overflow lol! (https://stackoverflow.com/a/78801142)

[bibhashdash]

Thanks for the course it's really good. I was wondering, is there a way to flag (or bookmark) a specific video so that we can easily come back to it later? I know we can leave it 'unchecked' but perhaps a quicker way would be to maybe filter and find all the bookmarked ones.
Anyway, just a thought. Great work on the course and looking forward to continuing my journey in web3.

[PatrickAlphaC]

Oooo interesting. Good feature request!

[SiewLin-AIDeaBuddy]

Thanks a lot for the excellent educative course materials. The option to learn sectioned videos in Updraft instead of a combined long hours video is greatly appreciated. Would like to give generic improvement feedbacks as below:

1. To include feature where user can easily take notes at any timestamp of the course tutorial videos in order to further deep dive on certain topics at later stage or to jot down topics that need attention. User can also easily view/search those notes made at various timestamps to revise the topics again instead of searching and rewatching the entire video to find the one that is relevant to revise.

2. It would be very helpful if after each new topic, a relevant past audit case study with solution or actual hacked protocols walk through is included at the end / or at the right time junction within the course to further enhance the understanding and applicability of the topic in real case.

3. Similar to 2 above, at the end of several topics/chapters/modules, if there is a relevant section in first flight / audits that closer to the taught topics, the inclusion of those info can be added apart from any planned challenges/quizzes. This is especially useful for those who just started in the field to get closer to something that they can attempt to after the lesson to test out their understanding of the topic rather than hunting around the various sources to find out that the real test/audit is far beyond from what they have learned at that point, and couldn’t really apply due to lots of missing pieces of associated knowledge. Perhaps can utilize / modify past first flight/audit to cater the learning needs/tests for targeted topics, this makes the learning more effective as it is closer to actual applications.

[EngrPips]

Interesting feedback.

[Equious]

@Eversmile12 Some food for thought.

[mpuj99]

Thanks for this course Patrick, it was amazing. Really well explained.
Two things I noticed during these course:

1. In section 3 - Develop DEFI protocol, in Lesson 20: Create the collateral redeem handler, when you create the line to get the collateral of a user:

uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(sender, address(collateral));

The function it has this order of arguments:

function getCollateralDepositedOfUser(address user, address token) external view returns(uint256)

First is the address of the user and then the address of the token, in the video you put first the token and then the user:

uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(address(collateral), sender);

I suppose it doens't fail because both are addresses, I looked at the logs and when we console maxAmountCollateralToRedeem is equal to zero. So never fails, if you put it good the arguments it fails with the assertion failed:
(totalWethValue + totalWbtcValue) >= totalSupply in InvariantTest.t.sol
I tried to fix it but it was hard, because I think the problem was that we were depositing collateral, minting and redeeming but in that lesson we weren't burning so, I fixed only for 5 invariant executions, creating redeeming and burning in the same function, on the 6th execution found some value that cracked the healthFactor, so I gave up because I spent too much time on creating the function to redeem and burn at the same time. So just telling you, maybe you can fix it in a new video with the arguments good positioned.
But overall, just want to say that the DEFI protocol section was my favourite section of Advanced Foundry, I learned a lot.

2. Is a silly thing but, in the last section: Security, in the lesson 3: Top security tools, from the minute 9:23 till 9:34 is all black, is nothing but just saying maybe you didn't notice it.
   Thank you very much, amazing course. With eager to start hitting the security and auditing course!!!!

Regards,

[EngrPips]

Awesome Feedback, I trust he will reply to this as soon as he is available.

[PatrickAlphaC]

So sorry I missed this! Thanks for the feedback here :) We will fix!

[thxpikachu]

In Blockchain Basics, Section 6 - The Purpose of Smart Contracts, the video cuts off a bit too early. The sentence was supposed to end with "and wash out the products that aren't actually contributing to Web3,"
but on Cyfrin Updraft, it abruptly stops at "aren't actually contribut-".

It's not a big deal, but my perfectionist brain can't bear it. :)

[EngrPips]

Thanks for the feedback, This will be attended to appropriately as soon as possible.

[Equious]

FYI @PatrickAlphaC 🙏

[MattSWeb3]

In "Blockchain Basics 11. Quiz: Blockchain Basics Mid Section Recap" Question 4 "What is the role of the gas price in ETH?" refers to the next video of the course "12. Introduction to Gas". Shouldn't the videos be the other way around? Since the quiz asks about something we didn't see up to that point.

[EngrPips]

Thanks for the feedback, This will be attended to appropriately as soon as possible.

[Dennnnny]

hey, I have a little question about quiz below:
In Foundry Fundamentals Section4 Smart Contract Lottery 11. Quiz: Smart Contract Lottery Intro
number 4 about How can you use the modulo operator (%) to determine if a number is even or odd?

I think If n % 2 != 1, the number is even. Otherwise, it's odd. this option is also correct (?)
because if a number % 2, is either 0 or 1

[EngrPips]

I think you have a point, This will be looked into as soon as possible.

[felixoder]

The logic you mentioned is partially correct, but not always reliable due to how modulus works with negative numbers. Here's why:

1. For positive numbers, n % 2 != 1 would work, because positive odd numbers will have a remainder of 1 when divided by 2 {Two}.
2. However, for negative odd numbers, the result of n % 2 is not necessarily 1. For example, -3 % 2 gives -1, not 1. So the check n % 2 != 1 would fail for negative odd numbers.

The safer way is to simply check n % 2 == 0 for even numbers (both positive and negative), and if not, the number is odd.

[MattSWeb3]

In Blockchain Basics course the written lesson on 16. Blockchain Overview has a small mistake in:
"A chain selection rule is implemented as a means to determine which blockchain is the real blockchain. Bitcoin (and prior to the merge, Ethereum), both use something called **Nakomoto** Consensus. This is a combination of Proof of Work (Etherum has since switched to Proof of Stake) and the longest chain rule."
It should be written "Nakamoto".

Thanks for the amazing work you guys have been doing. I'm loving the course!!

[EngrPips]

Thanks for pointing this out and this will be attended to as soon as possible.

[Equious]

This has been updated! In future you can definitely submit PRs for the written lessons to the dev branch on this repo: https://github.com/Cyfrin/Updraft

[khandelwalmoksh]

In "New discussion" section, "Preview" isn't working properly
my code:

       assertEq(fundMe.i_owner(), address(this));
   }```

my code ``` function testOwnerIsMsgSender() public {
       assertEq(fundMe.i_owner(), address(this));
} ```
   
![Screenshot (18)](https://github.com/user-attachments/assets/5c871d3f-68f9-46e0-9367-30255c426a95)
![Screenshot (19)](https://github.com/user-attachments/assets/1e3140e4-5800-46ff-b9d3-7043b5add0ec)


U can clearly see the difference, the 1st code is incomplete whereas, 2nd is complete

[EngrPips]

I am not sure I understand the issue you are pointing out here.

[khandelwalmoksh]

these must help you
U can clearly see the difference, the 1st code is incomplete whereas, 2nd is complete

[EngrPips]

I see, It will be looked into. thanks for the contribution.

[PatrickAlphaC]

Place the ``` on their own line, like this:

```
hi!
```

[khandelwalmoksh]

"IF YOU CAN" provide Patrick's codes used in Foundry Fundamentals, it would be very beneficial. Using the Solidity codes and the ones given in the repo, are giving countless errors. Even Phind ai can't help. And @EngrPips & others has to go through every line of the code provided to figure out what's wrong. This process eats up 2-3 days, thereby wasting the precious time of both, the questioner and solver. Thank you

[EngrPips]

Hello @khandelwalmoksh, I think you should not bother about the final code of each course but instead code along with Patrick, and like that, you won't run into too many problems, what do you think?

[PatrickAlphaC]

We do provide the code for each! Are you unable to find it?

[chainflash]

lesson 6 part 3 to 7 is a bit difficult for windows users

[EngrPips]

Thanks for pointing this out and this will be attended to as soon as possible.

[dvinubius]

Wrong answer for question 1 in the Quiz Fund Me Section Recap

Choice 3 is not entirely accurate. Constants cannot be assigned at any point, but must be assigned with an explicit value in the source code, so that the value is known at compile time. They are being specified at compile time and effectively set in storage on deployment.

Choice 4 is arguably correct though. Immutables can be set with one value when declared, and then updated when the constructor runs. Constants, on the other hand, can't ever be updated (which implies they were having another value before). They can only be specified once, at compile time, and then set accordingly when initialized, namely on deployment.

[EngrPips]

Thanks for pointing this out and this will be attended to as soon as possible.

[Equious]

Updated this question with some hopefully more clear/appropriate answers. Thanks for the feedback

[uddercover]

I noticed a blank part of the video in lesson 4, advanced foundry security section.
Timestamp: 9:22 - 9:34

[EngrPips]

Thanks for this feedback. This will be looked into.

[Equious]

This seems to be fixed. Thanks for the report.

[engAbody]

i had been in many other courses looking for problem to practice ,
i found that even chainlink make training question in code format at Githup

not hard and does not require special website

Thanks for consideration ,,

[intuitzer]

idk how but the vibe and aura of the course and instructor aka Patrick (hats off to him) just generates an extra chunk of interest in the field, it can't get better.
Thanks a lot. :)

[EngrPips]

You are welcome. It will only get better.

[MutteTejeshu]

Hi, I guess there was some mistake in the explanations of Max Priority Fee at 4:05 in Blockchain Basics - 15. Gas in depth. It was explained that Max Priority Fee is Max gas fee plus the Max Tip, but isn't that just the Max Tip?

And at 8:26 in the same video, it was said that the gas price we used was less than the max priority fee but the gas price is greater than the max priority fee.

Thanks for the great course and explanations.

[EngrPips]

Thanks for pointing out this @MutteTejeshu, @PatrickAlphaC will attend to this as soon as possible.

[codex-scribe]

It's proving really difficult to use the faucets right now, and it cost me a lot of sepoliaETH to deploy my first smart contract. Like .014 out of the .024 I had in my wallet (meaning I won't have enough to do a second smart contract unless I get a faucet to work again).
Maybe if Patrick knows someone in the Eth development community he can get a lot of sepolia ETH and send it out to people who request it through a thread like this. Perhaps if the requester can show work in their github relevant to this course. Then they could send 1 sETH to a user so they have a lot to work with for the future. I'm not looking forward to battling these faucets every day to get a little dribble of testnet ETH.

[codex-scribe]

The google faucet is the only one I've seen that worked that you didn't have to create an account on some website for, and to use it, you have to wait 10-20 minutes after your first request, and then make a second request.

[Aashim-Limbu]

@PatrickAlphaC
Thanks for such an amazing course . I would love to have a separate section on zkSync Rollups and discussion about everything to know about L2 and its jargons . As in the first section it self you've mentioned we'll discuss rollups in more depth later in the course.And for future would love to have course on the solana chain as well .Thank you for such an amazing course 🙏😀.

[EngrPips]

Great suggestion!

[ismaildawoodjee]

Great courses so far, can't wait to finish 'em all.

Is this also a place to point out bugs or mistakes? Because I found an incomplete sentence in Solidity Smart Contract Development, Section 3: Fund Me, 27. Quiz: Fund Me Section Recap, Question 5. How does the fallback function differ from the receive function in Solidity?, the answer is "The receive function is specifically designed to handle Ether transfers without data and is automatically invoked when Ether." and it just stops there.

Should it be "...is automatically invoked when Ether is sent"?

[EngrPips]

Hey @ismaildawoodjee, We are glad you are enjoying the course. You should use this GitHub's issue tab to report that issue.

[Imjolayemi]

A very great course to start with as a beginner, but I'm having problem accessing the tenderly link located in block chain basics tutorial 12 (sending your first transaction tenderly), kindly check this out or if you have a solution to this kindly do that.

[EngrPips]

Thanks for pointing this out. But it opens fine for me. Please check that everything is fine on your end. The link https://tenderly.co/?mtm_campaign=partner&mtm_kwd=cyfrin

[Imjolayemi]

Yes it is working, but I think the platform is working for some specific location or ip address. Because It works on my mobile phone immediately I changed it ip address here.

Is that how I will be accessing it, could there be any solution to that?

[EngrPips]

I am unsure why you have that problem. I didn't have any issue at all accessing the website maybe you can try a vpn on your computer.

[Imjolayemi]

Okay thanks very much

[EngrPips]

Anytime, Friend.

[TamirKalimi]

Hi,
I've finished the Blockchain Basics Course , and it’s been a fantastic introduction to the blockchain world. Thank you for putting this course together!
However, I noticed a couple of areas where the course could be improved for better clarity and flow:

1. Repetition between Lessons 19 and 26:
   The ending of Lesson 19: Blockchain Overview is identical to Lesson 26: Congratulations.
   Differentiating the content in Lesson 26 would make it feel more like a unique and memorable conclusion to the course.

2. Quiz Placement and Content:
   In the Lesson 22: Quiz: Blockchain Basics Recap, there are questions about rollup stages that are only introduced in Lesson 23: Rollup Stages. Swapping these lessons might improve the learning flow and ensure students have the background needed before taking the quiz.

[EngrPips]

Great feedback. @PatrickAlphaC @Equious

[Equious]

Thank you, we'll have a look this week!

[PatrickAlphaC]

This is great! Thank you!

[abdulsamed113]

When will the Arabic subtitle 🇸🇦 be added?

[EngrPips]

Interesting. @Equious