Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Grid Origin #95

Open
hbrincon opened this issue Mar 21, 2023 · 0 comments
Open

Common Grid Origin #95

hbrincon opened this issue Mar 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@hbrincon
Copy link
Contributor

Due to the sensitivity of VoidFinder to the choice of grid origin, it would be good to fix the origin to [0,0,0] for all void-finding (as discussed in UofR cosmology meetings).

Right now, changing the grid origin for SDSS DR7 from the minimum galaxy coordinates to [0,0,0] results in a negative buffer length calculated in _voidfinder.py. This stems from line 412, box = coords_max - grid_origin, which creates an array with negative elements and propagates into the buffer calculation.

If we want to enforce a common grid origin, one quick solution might be to assign the grid origin as the floor of the grid_origin user input, which should snap the grid to be aligned with [0,0,0]. Otherwise, we should find a working method to account for the sensitivity of VoidFinder to the grid.

@hbrincon hbrincon added the enhancement New feature or request label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant