Update org_golang_x_tools to master (bazel-contrib#1725)

Author: jayconrod

go/private/repositories.bzl

@@ -32,9 +32,9 @@ def go_rules_dependencies():
     _maybe(
         http_archive,
         name = "org_golang_x_tools",
-        # master, as of 2018-08-24
-        urls = ["https://codeload.github.com/golang/tools/zip/6c1c5e93cdc185a6ddf8f821166b3e631b0f8a72"],
-        strip_prefix = "tools-6c1c5e93cdc185a6ddf8f821166b3e631b0f8a72",
+        # master, as of 2018-09-18
+        urls = ["https://codeload.github.com/golang/tools/zip/90fa682c2a6e6a37b3a1364ce2fe1d5e41af9d6d"],
+        strip_prefix = "tools-90fa682c2a6e6a37b3a1364ce2fe1d5e41af9d6d",
         type = "zip",
         overlay = manifest["org_golang_x_tools"],
         # importpath = "golang.org/x/tools",

tests/integration/popular_repos/BUILD.bazel

@@ -162,7 +162,6 @@ test_suite(
         "@org_golang_x_tools//cmd/tip:go_default_test",
         "@org_golang_x_tools//go/ast/astutil:go_default_test",
         "@org_golang_x_tools//go/callgraph/static:go_default_test",
-        "@org_golang_x_tools//go/types/typeutil:go_default_test",
         "@org_golang_x_tools//go/vcs:go_default_test",
         "@org_golang_x_tools//godoc/redirect:go_default_test",
         "@org_golang_x_tools//godoc/vfs:go_default_test",

tests/integration/popular_repos/README.rst

@@ -161,7 +161,6 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
 * @org_golang_x_tools//cmd/tip:go_default_test
 * @org_golang_x_tools//go/ast/astutil:go_default_test
 * @org_golang_x_tools//go/callgraph/static:go_default_test
-* @org_golang_x_tools//go/types/typeutil:go_default_test
 * @org_golang_x_tools//go/vcs:go_default_test
 * @org_golang_x_tools//godoc/redirect:go_default_test
 * @org_golang_x_tools//godoc/vfs:go_default_test

tests/integration/popular_repos/popular_repos.py

@@ -106,6 +106,7 @@
             "godoc:go_default_test", # requires GOROOT and GOPATH
             "godoc/static:go_default_test", # requires data files
             "imports:go_default_test", # probably needs GOROOT
+            "go/types/typeutil:go_default_test", # requires GOROOT
         ],
     ),
 

third_party/manifest.bzl

@@ -761,6 +761,9 @@ manifest = {
         "@io_bazel_rules_go//third_party:org_golang_x_tools/cmd/toolstash/BUILD.bazel.in": "cmd/toolstash/BUILD.bazel",
         "@io_bazel_rules_go//third_party:org_golang_x_tools/container/intsets/BUILD.bazel.in": "container/intsets/BUILD.bazel",
         "@io_bazel_rules_go//third_party:org_golang_x_tools/cover/BUILD.bazel.in": "cover/BUILD.bazel",
+        "@io_bazel_rules_go//third_party:org_golang_x_tools/go/analysis/BUILD.bazel.in": "go/analysis/BUILD.bazel",
+        "@io_bazel_rules_go//third_party:org_golang_x_tools/go/analysis/plugin/findcall/BUILD.bazel.in": "go/analysis/plugin/findcall/BUILD.bazel",
+        "@io_bazel_rules_go//third_party:org_golang_x_tools/go/analysis/plugin/pkglemma/BUILD.bazel.in": "go/analysis/plugin/pkglemma/BUILD.bazel",
         "@io_bazel_rules_go//third_party:org_golang_x_tools/go/ast/astutil/BUILD.bazel.in": "go/ast/astutil/BUILD.bazel",
         "@io_bazel_rules_go//third_party:org_golang_x_tools/go/buildutil/BUILD.bazel.in": "go/buildutil/BUILD.bazel",
         "@io_bazel_rules_go//third_party:org_golang_x_tools/go/callgraph/BUILD.bazel.in": "go/callgraph/BUILD.bazel",

third_party/org_golang_x_tools/cmd/godoc/BUILD.bazel.in

@@ -39,9 +39,6 @@ go_binary(
 
 go_test(
     name = "go_default_test",
-    srcs = [
-        "godoc19_test.go",
-        "godoc_test.go",
-    ],
+    srcs = ["godoc_test.go"],
     embed = [":go_default_library"],
 )

third_party/org_golang_x_tools/go/analysis/BUILD.bazel.in

@@ -0,0 +1,11 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "go_default_library",
+    srcs = [
+        "analysis.go",
+        "validate.go",
+    ],
+    importpath = "golang.org/x/tools/go/analysis",
+    visibility = ["//visibility:public"],
+)

third_party/org_golang_x_tools/go/analysis/plugin/findcall/BUILD.bazel.in

@@ -0,0 +1,9 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "go_default_library",
+    srcs = ["findcall.go"],
+    importpath = "golang.org/x/tools/go/analysis/plugin/findcall",
+    visibility = ["//visibility:public"],
+    deps = ["//go/analysis:go_default_library"],
+)

third_party/org_golang_x_tools/go/analysis/plugin/pkglemma/BUILD.bazel.in

@@ -0,0 +1,9 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "go_default_library",
+    srcs = ["pkglemma.go"],
+    importpath = "golang.org/x/tools/go/analysis/plugin/pkglemma",
+    visibility = ["//visibility:public"],
+    deps = ["//go/analysis:go_default_library"],
+)

third_party/org_golang_x_tools/go/packages/BUILD.bazel.in

@@ -7,7 +7,9 @@ go_library(
         "external.go",
         "golist.go",
         "golist_fallback.go",
+        "golist_fallback_testmain.go",
         "packages.go",
+        "visit.go",
     ],
     importpath = "golang.org/x/tools/go/packages",
     visibility = ["//visibility:public"],
@@ -20,6 +22,7 @@ go_library(
 go_test(
     name = "go_default_test",
     srcs = [
+        "example_test.go",
         "packages110_test.go",
         "packages_test.go",
         "stdlib_test.go",

third_party/org_golang_x_tools/go/types/typeutil/BUILD.bazel.in

@@ -3,6 +3,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
 go_library(
     name = "go_default_library",
     srcs = [
+        "callee.go",
         "imports.go",
         "map.go",
         "methodsetcache.go",
@@ -15,6 +16,7 @@ go_library(
 go_test(
     name = "go_default_test",
     srcs = [
+        "callee_test.go",
         "example_test.go",
         "imports_test.go",
         "map_test.go",