Bump binary package version #19190
Bump binary package version #19190
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
agent_requirements.in
Outdated
| @@ -2,7 +2,7 @@ aerospike==7.1.1; sys_platform != 'win32' and sys_platform != 'darwin' | |||
| aws-requests-auth==0.4.3 | |||
| azure-identity==1.17.1 | |||
| beautifulsoup4==4.12.3 | |||
| binary==1.0.0 | |||
| binary==1.0.1; python_version >= '3.12' | |||
There was a problem hiding this comment.
Do we really need the conditional here? Do we expect this to be backported to py3.11 agents? If so shouldn't there be a line that specify what version to use if the python is not 3.12 and above?
binary==1.0.0; python_version < '3.12'
|
The changelog type |
|
The changelog type |
* bump binary package version * add python version condition * remove python version condition * changelo * changelog modified * changelog modified * changelog modified (cherry picked from commit e19e029)
* bump binary package version * add python version condition * remove python version condition * changelo * changelog modified * changelog modified * changelog modified (cherry picked from commit e19e029)
* bump binary package version * add python version condition * remove python version condition * changelo * changelog modified * changelog modified * changelog modified (cherry picked from commit e19e029) Co-authored-by: HadhemiDD <[email protected]>
What does this PR do?
Bump the binary package version to fix a warning that emerged with python 3.12.
The PR link with the fix: ofek/binary#11
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged