Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type validators to nested components #147

Closed
lukyanovas opened this issue Jul 3, 2018 · 1 comment
Closed

Add type validators to nested components #147

lukyanovas opened this issue Jul 3, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lukyanovas
Copy link
Contributor

Issue Type

feature request

Description

There is no type validators (prop-types and typescript declarations) in nested components now. It will be nice to have it.

Current Behavior

for example:

class Editing extends NestedOption<{
  allowAdding?: any;
  allowDeleting?: any;
  allowDragging?: any;
  allowResizing?: any;
  allowUpdating?: any;
}> {
  public static OptionName = "editing";
}

Expected Behavior

class Editing extends NestedOption<{
  allowAdding?: boolean;
  allowDeleting?: boolean;
  allowDragging?: boolean;
  allowResizing?: boolean;
  allowUpdating?: boolean;
}> {
  public static OptionName = "editing";
}

@lukyanovas lukyanovas added the enhancement New feature or request label Jul 3, 2018
@LexDX LexDX self-assigned this Dec 25, 2019
@LexDX
Copy link

LexDX commented Dec 25, 2019

We will consider this enhancement in the future, but I can't provide any timeframe.

@LexDX LexDX closed this as completed Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants