Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent option update if a similar object set #79

Closed
IlyaKhD opened this issue Apr 25, 2018 · 1 comment
Closed

Prevent option update if a similar object set #79

IlyaKhD opened this issue Apr 25, 2018 · 1 comment
Assignees
@IlyaKhD
Labels
enhancement New feature or request

Comments

@IlyaKhD
Copy link
Contributor

IlyaKhD commented Apr 25, 2018

Issue Type

Feature request

Description

Currently, option update prevention works well for scalar values (numbers, strings, etc.), object values have to be scoped.

Relates to the #78.

Current Behavior

An object set to an option is compared to the previous value by reference only.

Expected Behavior

A deep check for objects' equality also performed.

Environment Details

devextreme-react 18.1.1-alpha.3
@IlyaKhD IlyaKhD added the enhancement New feature or request label Apr 25, 2018
@IlyaKhD IlyaKhD changed the title Prevent option update when a similar object set Prevent option update if a similar object set Apr 25, 2018
@IlyaKhD IlyaKhD mentioned this issue Apr 25, 2018
Closed
@IlyaKhD IlyaKhD self-assigned this Apr 25, 2018
@IlyaKhD
Copy link
Contributor Author

IlyaKhD commented May 10, 2018

Since this affects option processing significantly, we decided not to add this enhancement this time. Waiting for more feedback.

@IlyaKhD IlyaKhD closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaKhD IlyaKhD

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IlyaKhD