Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ApertureValue to be nicer strings #760

Open
DominicOram opened this issue Jan 24, 2025 · 0 comments
Open

Clean up ApertureValue to be nicer strings #760

DominicOram opened this issue Jan 24, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Jan 24, 2025

Following #267 we have decoupled the enum used to set the aperture/scatterguard from that used in the GDA parameter files. However, the values of ApertureValue are still coupled to GDA as they are the strings that GDA will send to Hyperion when selecting the aperture. Thus we still have them set to SMALL_APERTURE etc. It would be cleaner to change them to more human readable values like Small as they are also what ends up in ispyb, this would mean we could remove the logic of changing the str interpretation

Note

It may just be easier to just do this once we no longer have GDA calling Hyperion

Acceptance Criteria

  • ApertureValues enum is more human readable
@DominicOram DominicOram added the good first issue Good for newcomers label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant