You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #267 we have decoupled the enum used to set the aperture/scatterguard from that used in the GDA parameter files. However, the values of ApertureValue are still coupled to GDA as they are the strings that GDA will send to Hyperion when selecting the aperture. Thus we still have them set to SMALL_APERTURE etc. It would be cleaner to change them to more human readable values like Small as they are also what ends up in ispyb, this would mean we could remove the logic of changing the str interpretation
Note
It may just be easier to just do this once we no longer have GDA calling Hyperion
Acceptance Criteria
ApertureValues enum is more human readable
The text was updated successfully, but these errors were encountered:
Following #267 we have decoupled the enum used to set the aperture/scatterguard from that used in the GDA parameter files. However, the values of
ApertureValue
are still coupled to GDA as they are the strings that GDA will send to Hyperion when selecting the aperture. Thus we still have them set toSMALL_APERTURE
etc. It would be cleaner to change them to more human readable values likeSmall
as they are also what ends up in ispyb, this would mean we could remove the logic of changing thestr
interpretationNote
It may just be easier to just do this once we no longer have GDA calling Hyperion
Acceptance Criteria
ApertureValues
enum is more human readableThe text was updated successfully, but these errors were encountered: