Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The web/waving-flag -sample needs some visual improvements #9

Open
DiscoNova opened this issue Nov 22, 2021 · 0 comments
Open

The web/waving-flag -sample needs some visual improvements #9

DiscoNova opened this issue Nov 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@DiscoNova
Copy link
Owner

When artist or title is long, the sample doesn't handle multiline text properly. When the layers are originally created, it should be rather simple to calculate a dynamic basefont size for both fields' containers so there'd be no need to support multiline text. The main effect most likely wouldn't suffer from this.

Also, at the moment the effect is implemented using 26 copies of the actual text like in Yusuko Nakaya's original proof of concept. This number of "layers" should be quite easy to reduce while still retaining the basic look and feel of the effect. Need to keep in mind that reducing the layers also means recreating part of the CSS, since the samples currently don't use any kind of preprocessor in order to be more easily approachable.

@DiscoNova DiscoNova added the enhancement New feature or request label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant