-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathpartitioned_table_cases_test.go
1297 lines (1186 loc) · 47.9 KB
/
partitioned_table_cases_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package migration_acceptance_tests
import (
"github.com/DoWithLogic/mysql-schema-diff/pkg/diff"
)
var partitionedTableAcceptanceTestCases = []acceptanceTestCase{
{
name: "No-op",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
bar TEXT COLLATE "POSIX",
fizz SERIAL,
identity BIGINT GENERATED ALWAYS AS IDENTITY ( MINVALUE 2 MAXVALUE 9 START 3 INCREMENT 4 CACHE 5 NO CYCLE ),
CHECK ( fizz > 0 ),
PRIMARY KEY (foo, id),
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
ALTER TABLE foobar REPLICA IDENTITY FULL;
ALTER TABLE foobar ENABLE ROW LEVEL SECURITY;
ALTER TABLE foobar FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
ALTER TABLE foobar_1 REPLICA IDENTITY DEFAULT ;
ALTER TABLE foobar_1 ENABLE ROW LEVEL SECURITY;
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
ALTER TABLE foobar_2 FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_unique_idx ON foobar(foo, bar);
-- local indexes
CREATE INDEX foobar_1_local_idx ON foobar_1(foo);
CREATE UNIQUE INDEX foobar_2_local_unique_idx ON foobar_2(foo);
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_1_local_unique_idx ON foobar_fk_1(foo);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo) REFERENCES foobar_2(foo);
ALTER TABLE foobar_1 ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo) REFERENCES foobar_fk_1(foo);
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
bar TEXT COLLATE "POSIX",
fizz SERIAL,
identity BIGINT GENERATED ALWAYS AS IDENTITY ( MINVALUE 2 MAXVALUE 9 START 3 INCREMENT 4 CACHE 5 NO CYCLE ),
CHECK ( fizz > 0 ),
PRIMARY KEY (foo, id),
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
ALTER TABLE foobar REPLICA IDENTITY FULL;
ALTER TABLE foobar ENABLE ROW LEVEL SECURITY;
ALTER TABLE foobar FORCE ROW LEVEL SECURITY;
-- partitions
ALTER TABLE foobar REPLICA IDENTITY FULL;
ALTER TABLE foobar ENABLE ROW LEVEL SECURITY;
ALTER TABLE foobar FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
ALTER TABLE foobar_1 REPLICA IDENTITY DEFAULT ;
ALTER TABLE foobar_1 ENABLE ROW LEVEL SECURITY;
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
ALTER TABLE foobar_2 FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_unique_idx ON foobar(foo, bar);
-- local indexes
CREATE INDEX foobar_1_local_idx ON foobar_1(foo);
CREATE UNIQUE INDEX foobar_2_local_unique_idx ON foobar_2(foo);
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
-- partitions
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_1_local_unique_idx ON foobar_fk_1(foo);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo) REFERENCES foobar_2(foo);
ALTER TABLE foobar_1 ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo) REFERENCES foobar_fk_1(foo);
`,
},
expectEmptyPlan: true,
},
{
name: "Create partitioned table with shared primary key and RLS enabled globally",
oldSchemaDDL: nil,
newSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1."Foobar"(
id INT,
foo VARCHAR(255),
bar TEXT COLLATE "POSIX" NOT NULL DEFAULT 'some default',
fizz SERIAL,
identity BIGINT GENERATED ALWAYS AS IDENTITY ( MINVALUE 2 MAXVALUE 9 START 3 INCREMENT 4 CACHE 5 NO CYCLE ),
CHECK ( fizz > 0 ),
PRIMARY KEY (foo, id),
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
ALTER TABLE schema_1."Foobar" REPLICA IDENTITY FULL;
ALTER TABLE schema_1."Foobar" ENABLE ROW LEVEL SECURITY;
ALTER TABLE schema_1."Foobar" FORCE ROW LEVEL SECURITY;
-- partitions
CREATE SCHEMA schema_2;
CREATE TABLE schema_2."FOOBAR_1" PARTITION OF schema_1."Foobar"(
foo NOT NULL,
bar NOT NULL
) FOR VALUES IN ('foo_1');
ALTER TABLE schema_2."FOOBAR_1" REPLICA IDENTITY NOTHING ;
CREATE TABLE schema_2.foobar_2 PARTITION OF schema_1."Foobar" FOR VALUES IN ('foo_2');
CREATE TABLE schema_2.foobar_3 PARTITION OF schema_1."Foobar" FOR VALUES IN ('foo_3');
-- partitioned indexes
ALTER TABLE schema_2.foobar_2 REPLICA IDENTITY FULL;
CREATE UNIQUE INDEX foobar_unique_idx ON schema_1."Foobar"(foo, fizz);
-- local indexes
CREATE INDEX foobar_1_local_idx ON schema_2."FOOBAR_1"(foo);
CREATE UNIQUE INDEX foobar_2_local_unique_idx ON schema_2.foobar_2(foo);
`,
},
},
{
name: "Create partitioned table with local primary keys and RLS enabled locally",
oldSchemaDDL: nil,
newSchemaDDL: []string{
`
CREATE TABLE "Foobar"(
id INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
CHECK ( fizz > 0 )
) PARTITION BY LIST (foo);
-- partitions
CREATE TABLE "FOOBAR_1" PARTITION OF "Foobar"(
foo NOT NULL,
bar NOT NULL,
PRIMARY KEY (foo, id)
) FOR VALUES IN ('foo_1');
ALTER TABLE "FOOBAR_1" ENABLE ROW LEVEL SECURITY;
CREATE TABLE foobar_2 PARTITION OF "Foobar"(
PRIMARY KEY (foo, bar)
) FOR VALUES IN ('foo_2');
ALTER TABLE foobar_2 FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_3 PARTITION OF "Foobar"(
PRIMARY KEY (foo, fizz),
UNIQUE (foo, bar)
) FOR VALUES IN ('foo_3');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_unique_idx ON "Foobar"(foo, bar);
-- local indexes
CREATE INDEX foobar_1_local_idx ON "FOOBAR_1"(foo);
CREATE UNIQUE INDEX foobar_2_local_unique_idx ON foobar_2(foo);
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
-- partitions
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_1_local_unique_idx ON foobar_fk_1(foo);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES "Foobar"(foo, bar);
ALTER TABLE "Foobar" ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo) REFERENCES foobar_2(foo);
ALTER TABLE "FOOBAR_1" ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo) REFERENCES foobar_fk_1(foo);
`,
},
},
{
name: "Drop table",
oldSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1."Foobar"(
id INT,
foo VARCHAR(255),
bar TEXT,
fizz SERIAL,
CHECK ( fizz > 0 ),
PRIMARY KEY (foo, id),
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
CREATE SCHEMA schema_2;
CREATE TABLE schema_2."FOOBAR_1" PARTITION OF schema_1."Foobar"(
foo NOT NULL,
bar NOT NULL
) FOR VALUES IN ('foo_1');
-- partitions
CREATE TABLE schema_2.foobar_2 PARTITION OF schema_1."Foobar" FOR VALUES IN ('foo_2');
CREATE TABLE schema_2.foobar_3 PARTITION OF schema_1."Foobar" FOR VALUES IN ('foo_3');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_unique_idx ON schema_1."Foobar"(foo, bar);
-- local indexes
CREATE INDEX foobar_1_local_idx ON schema_2."FOOBAR_1"(foo);
CREATE UNIQUE INDEX foobar_2_local_unique_idx ON schema_2.foobar_2(foo);
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
-- partitions
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_1_local_unique_idx ON foobar_fk_1(foo);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES schema_1."Foobar"(foo, bar);
ALTER TABLE schema_1."Foobar" ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo) REFERENCES schema_2.foobar_2(foo);
ALTER TABLE schema_2."FOOBAR_1" ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo) REFERENCES foobar_fk_1(foo);
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeDeletesData,
},
newSchemaDDL: nil,
},
{
name: "Add and drop partitioned table (conflicting schemas)",
oldSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1.foobar(
foo VARCHAR(255)
) PARTITION BY LIST (foo);
CREATE SCHEMA schema_2;
CREATE TABLE schema_2.foobar_1 PARTITION OF schema_1.foobar FOR VALUES IN ('foo_1');
`,
},
newSchemaDDL: []string{`
CREATE SCHEMA schema_3;
CREATE TABLE schema_3.foobar(
foo VARCHAR(255)
) PARTITION BY LIST (foo);
CREATE SCHEMA schema_4;
CREATE TABLE schema_4.foobar_1 PARTITION OF schema_3.foobar FOR VALUES IN ('foo_1');
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeDeletesData,
},
},
{
name: "Alter replica identity of parent and children",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
ALTER TABLE foobar REPLICA IDENTITY FULL;
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
ALTER TABLE foobar_1 REPLICA IDENTITY NOTHING;
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
ALTER TABLE foobar REPLICA IDENTITY DEFAULT;
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
ALTER TABLE foobar_1 REPLICA IDENTITY FULL;
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
ALTER TABLE foobar_2 REPLICA IDENTITY FULL;
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeCorrectness,
},
},
{
name: "Enable RLS of parent and children",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
ALTER TABLE foobar ENABLE ROW LEVEL SECURITY;
ALTER TABLE foobar FORCE ROW LEVEL SECURITY;
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
ALTER TABLE foobar_1 ENABLE ROW LEVEL SECURITY;
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
ALTER TABLE foobar_2 FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeAuthzUpdate,
},
},
{
name: "Disable RLS of parent and children",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
ALTER TABLE foobar ENABLE ROW LEVEL SECURITY;
ALTER TABLE foobar FORCE ROW LEVEL SECURITY;
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
ALTER TABLE foobar_1 ENABLE ROW LEVEL SECURITY;
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
ALTER TABLE foobar_2 FORCE ROW LEVEL SECURITY;
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeAuthzUpdate,
},
},
{
name: "Alter table: New primary key, new unique constraint, dropped unique constraint, change column types, delete partitioned index, new partitioned index, delete local index, add local index, validate check constraint, validate FK, delete FK",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
bar TEXT COLLATE "C",
fizz SERIAL,
PRIMARY KEY (foo, id),
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
-- check constraints
ALTER TABLE foobar ADD CONSTRAINT some_check_constraint CHECK ( fizz > 0 ) NOT VALID;
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar(
foo NOT NULL,
bar NOT NULL
) FOR VALUES IN ('foo_1');
CREATE TABLE foobar_2 PARTITION OF foobar FOR VALUES IN ('foo_2');
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_unique_idx ON foobar(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_1_local_unique_idx ON foobar_1(foo);
CREATE INDEX foobar_2_local_idx ON foobar_1(foo);
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_fk_1_local_unique_idx ON foobar_fk_1(foo);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo) REFERENCES foobar_1(foo) NOT VALID;
ALTER TABLE foobar_1 ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo) REFERENCES foobar_fk_1(foo) NOT VALID;
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id TEXT,
foo VARCHAR(255),
bar TEXT COLLATE "POSIX",
fizz TEXT,
PRIMARY KEY (foo, id),
UNIQUE (foo, fizz)
) PARTITION BY LIST (foo);
-- check constraint
ALTER TABLE foobar ADD CONSTRAINT some_check_constraint CHECK ( LENGTH(fizz) > 0 );
-- partitions
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
CREATE TABLE foobar_2 PARTITION OF foobar(
bar NOT NULL
) FOR VALUES IN ('foo_2');
CREATE TABLE foobar_3 PARTITION OF foobar FOR VALUES IN ('foo_3');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_some_idx ON foobar(foo, fizz);
-- local indexes
CREATE UNIQUE INDEX foobar_1_local_unique_idx ON foobar_1(foo);
CREATE INDEX foobar_3_local_idx ON foobar_3(foo, bar);
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- local indexes
CREATE UNIQUE INDEX foobar_fk_1_local_unique_idx ON foobar_fk_1(foo);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo) REFERENCES foobar_1(foo);
ALTER TABLE foobar_1 ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo) REFERENCES foobar_fk_1(foo);
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeAcquiresAccessExclusiveLock,
diff.MigrationHazardTypeDeletesData,
diff.MigrationHazardTypeImpactsDatabasePerformance,
diff.MigrationHazardTypeIndexDropped,
diff.MigrationHazardTypeIndexBuild,
},
},
{
name: "Changing partition key def errors",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
bar TEXT,
fizz INT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
foo VARCHAR(255),
bar TEXT,
fizz INT
) PARTITION BY LIST (bar);
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
`,
},
expectedPlanErrorIs: diff.ErrNotImplemented,
},
{
name: "Unpartitioned to partitioned",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
);
CREATE INDEX some_idx on foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on foobar(foo, bar);
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
);
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
CREATE INDEX some_idx on foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on foobar(foo, bar);
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeDeletesData,
},
},
{
name: "Unpartitioned to partitioned and child tables already exist",
oldSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1.foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, fizz)
);
CREATE INDEX some_idx on schema_1.foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on schema_1.foobar(foo, bar);
CREATE SCHEMA schema_2;
CREATE TABLE schema_2.foobar_1(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, fizz)
);
CREATE INDEX foobar_1_id_idx on schema_1.foobar(id);
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON schema_1.foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON schema_2.foobar_1
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
);
CREATE TABLE foobar_fk_1(
foo VARCHAR(255),
bar TEXT
);
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES schema_1.foobar( foo, bar);
ALTER TABLE schema_1.foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_foo_bar_fkey FOREIGN KEY (foo, bar) REFERENCES schema_1.foobar( foo, bar);
ALTER TABLE schema_1.foobar ADD CONSTRAINT foobar_foo_bar_fkey FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
newSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1.foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, fizz)
) PARTITION BY LIST (foo);
CREATE INDEX some_idx on schema_1.foobar( id);
CREATE UNIQUE INDEX foobar_unique_idx on schema_1.foobar( foo, bar);
CREATE SCHEMA schema_2;
CREATE TABLE schema_2.foobar_1 PARTITION OF schema_1.foobar FOR VALUES IN ('foo_1');
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON schema_1.foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES schema_1.foobar( foo, bar);
ALTER TABLE schema_1.foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeDeletesData,
},
},
{
name: "Partitioned to unpartitioned",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
CREATE INDEX some_idx on foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on foobar(foo, bar);
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
);
CREATE INDEX some_idx on foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on foobar(foo, bar);
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
);
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeDeletesData,
},
},
{
name: "Partitioned to unpartitioned and child tables still exist",
oldSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
) PARTITION BY LIST (foo);
CREATE INDEX some_idx on foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on foobar(foo, bar);
CREATE TABLE foobar_1 PARTITION OF foobar FOR VALUES IN ('foo_1');
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
) PARTITION BY LIST (foo);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
newSchemaDDL: []string{
`
CREATE TABLE foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
);
CREATE INDEX some_idx on foobar(id);
CREATE UNIQUE INDEX foobar_unique_idx on foobar(foo, bar);
CREATE TABLE foobar_1(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
UNIQUE (foo, bar)
);
CREATE INDEX foobar_1_id_idx on foobar(id);
CREATE FUNCTION increment_version() RETURNS TRIGGER AS $$
BEGIN
NEW.version = OLD.version + 1;
RETURN NEW;
END;
$$ language 'plpgsql';
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TRIGGER some_update_trigger
BEFORE UPDATE ON foobar_1
FOR EACH ROW
WHEN (OLD.* IS DISTINCT FROM NEW.*)
EXECUTE PROCEDURE increment_version();
CREATE TABLE foobar_fk(
foo VARCHAR(255),
bar TEXT
);
CREATE TABLE foobar_fk_1(
foo VARCHAR(255),
bar TEXT
);
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_foo_bar_fkey FOREIGN KEY (foo, bar) REFERENCES foobar(foo, bar);
ALTER TABLE foobar ADD CONSTRAINT foobar_foo_bar_fkey FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
expectedHazardTypes: []diff.MigrationHazardType{
diff.MigrationHazardTypeDeletesData,
},
},
{
name: "Adding a partition",
oldSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1.foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
CHECK ( fizz > 0 ),
PRIMARY KEY (foo, id),
UNIQUE (foo, fizz)
) PARTITION BY LIST (foo);
-- partitioned indexes
CREATE UNIQUE INDEX some_partitioned_idx ON schema_1.foobar(foo, bar);
CREATE TABLE foobar_fk(
id INT,
foo VARCHAR(255),
bar TEXT,
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES schema_1.foobar(foo, bar);
ALTER TABLE schema_1.foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
`,
},
newSchemaDDL: []string{
`
CREATE SCHEMA schema_1;
CREATE TABLE schema_1.foobar(
id INT,
version INT,
fizz SERIAL,
foo VARCHAR(255),
bar TEXT,
CHECK ( fizz > 0 ),
PRIMARY KEY (foo, id),
UNIQUE (foo, fizz)
) PARTITION BY LIST (foo);
CREATE SCHEMA schema_2;
CREATE TABLE schema_2.foobar_1 PARTITION OF schema_1.foobar FOR VALUES IN ('foo_1');
-- partitioned indexes
CREATE UNIQUE INDEX some_partitioned_idx ON schema_1.foobar(foo, bar);
CREATE TABLE foobar_fk(
id INT,
foo VARCHAR(255),
bar TEXT,
PRIMARY KEY (foo, id)
) PARTITION BY LIST (foo);
CREATE UNIQUE INDEX foobar_fk_unique_idx ON foobar_fk(foo, bar);
CREATE TABLE foobar_fk_1 PARTITION OF foobar_fk FOR VALUES IN ('foo_1');
-- foreign keys
-- create a circular dependency of foreign keys (this is allowed)
ALTER TABLE foobar_fk ADD CONSTRAINT foobar_fk_fk FOREIGN KEY (foo, bar) REFERENCES schema_1.foobar(foo, bar);
ALTER TABLE schema_1.foobar ADD CONSTRAINT foobar_fk FOREIGN KEY (foo, bar) REFERENCES foobar_fk(foo, bar);
-- local local foreign keys
ALTER TABLE foobar_fk_1 ADD CONSTRAINT foobar_fk_1_fk FOREIGN KEY (foo, id) REFERENCES schema_2.foobar_1(foo, id);
ALTER TABLE schema_2.foobar_1 ADD CONSTRAINT foobar_1_fk FOREIGN KEY (foo, id) REFERENCES foobar_fk_1(foo, id);
`,
},
},
{
name: "Adding a partition with local primary key that can back the unique index",
oldSchemaDDL: []string{