Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seasonal ice is misclassified as a subclass of sea ice #115

Open
rduerr opened this issue Feb 27, 2019 · 4 comments
Open

Seasonal ice is misclassified as a subclass of sea ice #115

rduerr opened this issue Feb 27, 2019 · 4 comments
Labels
Cryosphere Issues related to cryospheric terminology realm
Milestone

Comments

@rduerr
Copy link
Contributor

rduerr commented Feb 27, 2019

The ENVO IRI is: http://purl.obolibrary.org/obo/ENVO_03000071


The issue is that seasonal ice is an area of the ocean where ice is only there seasonally, which is not a concept that is captured by sea ice.

@lewismc
Copy link
Member

lewismc commented Oct 14, 2019

@rduerr do you want to propose a PR for this one? I don 't want to try and then screw it up. Thanks

@lewismc lewismc added the realm label Oct 14, 2019
@lewismc
Copy link
Member

lewismc commented Oct 14, 2019

The relevant code is at

sweet/src/realmCryo.ttl

Lines 239 to 242 in 4bcfb83

### http://sweetontology.net/realmCryo/SeasonalIce
cryo:SeasonalIce rdf:type owl:Class ;
rdfs:subClassOf cryo:SeaIce ;
rdfs:label "seasonal ice"@en .

@rduerr
Copy link
Contributor Author

rduerr commented Oct 14, 2019

@lewismc Yes, I always was planning on coming back to all of the SWEET tickets the Harmonization group was authoring; but we were concentrating on the ENVO stuff to begin with. I think we should start dealing with the SWEET issues as well... That's something we can tackle when Pier isn't available to approve changed in ENVO...

@lewismc
Copy link
Member

lewismc commented Oct 14, 2019

That’s absolutely fine @rduerr thanks for letting me know.

@lewismc lewismc added this to the 3.5.0 milestone Nov 21, 2019
@rduerr rduerr added the Cryosphere Issues related to cryospheric terminology label May 20, 2020
@brandonnodnarb brandonnodnarb modified the milestones: 3.5.0, 3.6.0 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cryosphere Issues related to cryospheric terminology realm
Projects
None yet
Development

No branches or pull requests

3 participants