Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Report Endpoint(s) hardening todo #4

Open
jasonmzx opened this issue Sep 5, 2023 · 1 comment
Open

Report Endpoint(s) hardening todo #4

jasonmzx opened this issue Sep 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jasonmzx
Copy link
Member

jasonmzx commented Sep 5, 2023

image

Clean up the Description before appending it to the Report that will be committed, maybe use StringHelper class and raise error if something fails?

Also Look for general points of weakness within Endpoint, do a bit more exhaustive testing (potentially look into rate-limiting / anti-spam techniques) and just harden up the endpoint a bit more since we're writing to the DB with this one

../api/EndpointReport.java

@jasonmzx jasonmzx added the enhancement New feature or request label Sep 5, 2023
@Minnowo
Copy link
Member

Minnowo commented Sep 5, 2023

I think non-ASCII is fine, I don't see why that would cause any problems, but it's important to length check all the string values to ensure they're less than or equal to their column length in the db.

I'm not sure how hibernate will handle string length which is longer than the db column.

evangoldenberg added a commit to evangoldenberg/searchIndex that referenced this issue Sep 12, 2023
Minnowo added a commit that referenced this issue Sep 13, 2023
added length check to Issue #4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants