Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Rewrite to Jetpack Compose #368

Open
5 of 17 tasks
EdricChan03 opened this issue Sep 28, 2022 · 3 comments
Open
5 of 17 tasks

[Refactor] Rewrite to Jetpack Compose #368

EdricChan03 opened this issue Sep 28, 2022 · 3 comments
Assignees
Labels
enhancement Enhancements to the Android app. For the web version, please use the other repo instead. epic Mega issues containing sub-tasks/issues to complete good first issue Issues/PRs for new contributors to look at. help wanted Issues/ PRs that will benefit help from the community. migration Issues/PRs for long-term changes to be made

Comments

@EdricChan03
Copy link
Owner

EdricChan03 commented Sep 28, 2022

Because why not

Current progress

(Last updated 24 Apr 2024)

Theming

  • Typography
  • Colours
  • Theme composable

Widgets

  • Modal bottom sheet
  • Main switch bar

Features

@EdricChan03 EdricChan03 added enhancement Enhancements to the Android app. For the web version, please use the other repo instead. help wanted Issues/ PRs that will benefit help from the community. priority: non-critical good first issue Issues/PRs for new contributors to look at. labels Sep 28, 2022
@EdricChan03 EdricChan03 moved this to Todo in StudyBuddy Sep 28, 2022
@imashnake0
Copy link

Is this up for grabs? 👁️

@EdricChan03 EdricChan03 moved this from Todo to In Progress in StudyBuddy Dec 12, 2022
@EdricChan03
Copy link
Owner Author

Current status:

Help activity

Currently migrating to Jetpack Compose - so far, it's been mostly done, just need some additional testing (and pushing of commits - currently, you can find the WIP changes in the refactor/feature/help-compose branch)

Settings activity

Also working on it. Mostly done, needs some thoughts on how auth would be integrated in the module (Separate module for auth? Or just add the Firebase Auth dependency and use it as-is?).

No changes published as of yet, but stay tuned 👀

@EdricChan03
Copy link
Owner Author

Currently migrating to Jetpack Compose - so far, it's been mostly done, just need some additional testing (and pushing of commits - currently, you can find the WIP changes in the refactor/feature/help-compose branch)

*An addendum on this: adding Jetpack Compose to the app requires additional setup, so the preliminary changes will be adding Compose (in the feat/compose-setup branch - see #406), then migrating the help module to Compose.

@EdricChan03 EdricChan03 moved this from In Progress to Todo in StudyBuddy May 31, 2023
@EdricChan03 EdricChan03 moved this from Todo to Done in StudyBuddy May 31, 2023
@EdricChan03 EdricChan03 moved this from Done to In Progress in StudyBuddy Jun 18, 2023
@EdricChan03 EdricChan03 added migration Issues/PRs for long-term changes to be made and removed priority: non-critical labels Sep 20, 2023
@EdricChan03 EdricChan03 self-assigned this Oct 15, 2023
EdricChan03 added a commit that referenced this issue Nov 13, 2023
This is an initial port of the modal-bottom-sheet Gradle submodule to
use Compose.

* Selection state is now handled on the group data class as a list of
  indexes rather than a list of items, to allow for easier flexability.
  This ensures a single-source of truth for the list of items.

* An additional constructor was introduced to allow for a `Map` of key
  `BottomSheetOption` to whether it's selected (`Boolean`) (i.e.
  `Map<BottomSheetOption, Boolean>`.

See #368 and  #369

* Added unit + instrumentation tests for bottom sheet data + UI (#387)
@EdricChan03 EdricChan03 added this to the v1.1.0 milestone Jan 17, 2024
@EdricChan03 EdricChan03 added the epic Mega issues containing sub-tasks/issues to complete label Mar 13, 2024
@EdricChan03 EdricChan03 pinned this issue Mar 13, 2024
@EdricChan03 EdricChan03 modified the milestones: v1.1.0, The Great Rewrite Mar 14, 2024
EdricChan03 added a commit that referenced this issue Apr 16, 2024
See #368 and #585

* Scaffold `:core:auth:compose` module
* Include module in settings script
* Add composable to provide CompositionLocals
EdricChan03 added a commit that referenced this issue Nov 17, 2024
* Add preview composable for use in the layout editor

For #584 and #368
EdricChan03 added a commit that referenced this issue Dec 14, 2024
EdricChan03 added a commit that referenced this issue Dec 14, 2024
* Add GeneralSettingsViewModel
* Remove existing preference layout
* Remove languages preference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to the Android app. For the web version, please use the other repo instead. epic Mega issues containing sub-tasks/issues to complete good first issue Issues/PRs for new contributors to look at. help wanted Issues/ PRs that will benefit help from the community. migration Issues/PRs for long-term changes to be made
Projects
Status: In Progress
Development

No branches or pull requests

2 participants