dont set uncapped milestone status to PAID

ElMejorge · Jan 31, 2019 · c0ee147 · c0ee147
1 parent e8f3c72
commit c0ee147
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/blockchain/milestones.js b/src/blockchain/milestones.js
@@ -249,6 +249,9 @@ const milestonesFactory = app => {
         return;
       }
 
+      // never set uncapped milestones as PAID
+      if (!milestones[0].maxAmount) return;
+
       const donations = await app.service('donations').find({
         paginate: false,
         query: {

diff --git a/src/services/donations/donations.hooks.js b/src/services/donations/donations.hooks.js
@@ -291,6 +291,10 @@ const updateMilestoneIfNotPledged = () => async context => {
     donation.ownerType === AdminTypes.MILESTONE &&
     [DonationStatus.PAYING, DonationStatus.PAID].includes(donation.status)
   ) {
+    const milestone = await context.app.service('milestones').get(donation.ownerTypeId);
+    // never set uncapped milestones as PAID
+    if (!milestone.maxAmount) return;
+
     const donations = await context.app.service('donations').find({
       paginate: false,
       query: {