Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopupActions uses StorageHelper from the front end #35

Open
Elec0 opened this issue Nov 17, 2024 · 0 comments
Open

PopupActions uses StorageHelper from the front end #35

Elec0 opened this issue Nov 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Elec0
Copy link
Owner

Elec0 commented Nov 17, 2024

StorageHelper only expects to be used from the background script, but it appears PopupActions is calling it directly.

The messaging should be changed so the other PopupActions methods also receive the updated workspaces from the background script, like PopupActions.openWorkspace already does.

See

  • PopupActions.deleteWorkspace
  • PopupActions.renameWorkspace
@Elec0 Elec0 added the bug Something isn't working label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant