Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listfunds missing closed channel output #8169

Closed
grubles opened this issue Mar 18, 2025 · 3 comments · Fixed by #8175
Closed

listfunds missing closed channel output #8169

grubles opened this issue Mar 18, 2025 · 3 comments · Fixed by #8175
Assignees
@rustyrussell
Labels
bug
Milestone
v25.05

Comments

@grubles
Copy link
Contributor

grubles commented Mar 18, 2025

CLN: 0e7615b

After closing a channel, listfunds is missing the output that is tracked in the debug logs below. I've tried a dev-rescan-outputs with no success.

2025-03-17T13:13:53.967Z DEBUG   <node id>-closingd-chan#14608: billboard perm: We agreed on a closing fee of 431 satoshi for tx:<txid>                                                                                                                                                                                      
2025-03-17T13:13:53.970Z DEBUG   lightningd: Broadcasting txid <txid> for "cli:close#185905"                                                                  
2025-03-17T13:24:38.791Z DEBUG   <node id>-chan#14608: Got UTXO spend for :0: <txid>                                                                                                                                                                         
2025-03-17T13:24:38.791Z UNUSUAL <node id>-chan#14608: Peer permanent failure in CLOSINGD_COMPLETE: Funding transaction spent: onchain txid <txid> (reason=unknown)                                                                                                                                                          
2025-03-17T13:24:38.791Z UNUSUAL <node id>-chan#14608: Not dropping our unilateral close onchain since we already saw <txid> confirm.                                                                                                                                                                                        
2025-03-17T13:24:39.023Z DEBUG   lightningd: Got first depth change 0->1 for <txid>                                                                           
2025-03-17T13:24:39.139Z DEBUG   <node id>-onchaind-chan#14608: Resolved FUNDING_TRANSACTION/FUNDING_OUTPUT by MUTUAL_CLOSE (txid)                                                                                                                                                                                         
2025-03-17T13:25:09.383Z DEBUG   lightningd: Got depth change 1->2 for <txid>                                                                                 
2025-03-17T13:31:40.157Z DEBUG   lightningd: Got depth change 2->3 for <txid>                                                                                 
2025-03-17T13:59:12.089Z DEBUG   lightningd: Got depth change 3->4 for <txid>                                                                                 
2025-03-17T14:17:13.862Z DEBUG   lightningd: Got depth change 4->5 for <txid>                                                                                 
2025-03-17T14:42:45.477Z DEBUG   lightningd: Got depth change 5->6 for <txid>                                                                                 
2025-03-17T14:48:46.145Z DEBUG   lightningd: Got depth change 6->7 for <txid>                                                                                 
2025-03-17T14:51:46.717Z DEBUG   lightningd: Got depth change 7->8 for <txid>                                                                                 
2025-03-17T14:53:46.959Z DEBUG   lightningd: Got depth change 8->9 for <txid>                                                                                 
2025-03-17T14:58:47.377Z DEBUG   lightningd: Got depth change 9->10 for <txid>                                                                                
2025-03-17T15:16:48.315Z DEBUG   lightningd: Got depth change 10->11 for <txid>                                                                               
2025-03-17T15:17:18.510Z DEBUG   lightningd: Got depth change 11->12 for <txid>                                                                               
2025-03-17T15:22:48.965Z DEBUG   lightningd: Got depth change 12->13 for <txid>                                                                               
2025-03-17T16:00:20.335Z DEBUG   lightningd: Got depth change 13->14 for <txid>                                                                               
2025-03-17T16:19:21.393Z DEBUG   lightningd: Got depth change 14->15 for <txid>                                                                               2025-03-17T16:29:22.144Z DEBUG   lightningd: Got depth change 15->16 for <txid>                                                                               
2025-03-17T16:41:23.225Z DEBUG   lightningd: Got depth change 16->17 for <txid>                                                                               2025-03-17T16:48:54.469Z DEBUG   lightningd: Got depth change 17->18 for <txid>                                                                               
2025-03-17T16:52:25.112Z DEBUG   lightningd: Got depth change 18->19 for <txid>                                                                               
2025-03-17T16:53:25.492Z DEBUG   lightningd: Got depth change 19->20 for <txid>                                                                               
2025-03-17T16:57:26.196Z DEBUG   lightningd: Got depth change 20->21 for <txid>                                                                               
2025-03-17T16:58:56.610Z DEBUG   lightningd: Got depth change 21->22 for <txid>                                                                               
2025-03-17T17:14:57.706Z DEBUG   lightningd: Got depth change 22->23 for <txid>                                                                               
2025-03-17T17:19:28.396Z DEBUG   lightningd: Got depth change 23->24 for <txid>    
2025-03-17T17:35:29.429Z DEBUG   lightningd: Got depth change 24->25 for <txid>                                                                               
2025-03-17T17:35:59.647Z DEBUG   lightningd: Got depth change 25->26 for <txid>                                                                               
2025-03-17T17:45:00.296Z DEBUG   lightningd: Got depth change 26->27 for <txid>                                                                               
2025-03-17T17:47:30.521Z DEBUG   lightningd: Got depth change 27->28 for <txid>                                                                               
2025-03-17T18:13:31.800Z DEBUG   lightningd: Got depth change 28->29 for <txid>
2025-03-17T18:14:02.181Z DEBUG   lightningd: Got depth change 29->30 for <txid>
2025-03-17T18:19:32.537Z DEBUG   lightningd: Got depth change 30->31 for <txid>
2025-03-17T18:23:02.793Z DEBUG   lightningd: Got depth change 31->32 for <txid>
2025-03-17T18:40:03.512Z DEBUG   lightningd: Got depth change 32->33 for <txid>                                                                               
2025-03-17T18:52:34.476Z DEBUG   lightningd: Got depth change 33->34 for <txid>                                                                               
2025-03-17T19:04:05.228Z DEBUG   lightningd: Got depth change 34->35 for <txid>                                                                               
2025-03-17T19:14:35.778Z DEBUG   lightningd: Got depth change 35->36 for <txid>                                                                               
2025-03-17T19:16:36.165Z DEBUG   lightningd: Got depth change 36->38 for <txid>                                                                               
2025-03-17T19:18:36.421Z DEBUG   lightningd: Got depth change 38->39 for <txid>                                                                               
2025-03-17T19:21:36.680Z DEBUG   lightningd: Got depth change 39->40 for <txid>
2025-03-17T19:24:36.953Z DEBUG   lightningd: Got depth change 40->41 for <txid>
2025-03-17T19:25:07.110Z DEBUG   lightningd: Got depth change 41->42 for <txid>
2025-03-17T19:31:07.597Z DEBUG   lightningd: Got depth change 42->43 for <txid>
2025-03-17T19:37:38.038Z DEBUG   lightningd: Got depth change 43->44 for <txid>
2025-03-17T19:38:38.207Z DEBUG   lightningd: Got depth change 44->45 for <txid>
2025-03-17T19:51:39.096Z DEBUG   lightningd: Got depth change 45->46 for <txid>
2025-03-17T19:58:09.459Z DEBUG   lightningd: Got depth change 46->47 for <txid>
2025-03-17T20:19:10.470Z DEBUG   lightningd: Got depth change 47->48 for <txid>
2025-03-17T20:27:41.015Z DEBUG   lightningd: Got depth change 48->49 for <txid>
2025-03-17T20:32:11.398Z DEBUG   lightningd: Got depth change 49->50 for <txid>
2025-03-17T20:37:41.781Z DEBUG   lightningd: Got depth change 50->51 for <txid>
2025-03-17T20:55:12.666Z DEBUG   lightningd: Got depth change 51->52 for <txid>
2025-03-17T21:03:43.190Z DEBUG   lightningd: Got depth change 52->53 for <txid>
2025-03-17T21:04:43.361Z DEBUG   lightningd: Got depth change 53->54 for <txid>
2025-03-17T21:16:44.096Z DEBUG   lightningd: Got depth change 54->55 for <txid>
2025-03-17T21:26:14.691Z DEBUG   lightningd: Got depth change 55->56 for <txid>
2025-03-17T21:28:14.935Z DEBUG   lightningd: Got depth change 56->57 for <txid>
2025-03-17T21:33:58.633Z UNUSUAL <node id>-chan#14608: Peer permanent failure in ONCHAIN: Funding transaction spent: onchain txid <txid> (reason=unknown)
2025-03-17T21:33:58.633Z UNUSUAL <node id>-chan#14608: Not dropping our unilateral close onchain since we already saw <txid> confirm.
2025-03-17T21:33:58.772Z DEBUG   <node id>-onchaind-chan#14608: Resolved FUNDING_TRANSACTION/FUNDING_OUTPUT by MUTUAL_CLOSE (txid)
2025-03-17T21:38:33.891Z DEBUG   lightningd: Got first depth change 0->58 for <txid>
2025-03-17T21:52:04.536Z DEBUG   lightningd: Got depth change 58->59 for <txid>
2025-03-17T21:56:34.846Z DEBUG   lightningd: Got depth change 59->60 for <txid>
2025-03-17T22:00:05.107Z DEBUG   lightningd: Got depth change 60->61 for <txid>
2025-03-17T22:11:05.763Z DEBUG   lightningd: Got depth change 61->62 for <txid>
2025-03-17T22:35:06.764Z DEBUG   lightningd: Got depth change 62->63 for <txid>
2025-03-17T22:40:07.077Z DEBUG   lightningd: Got depth change 63->64 for <txid>
2025-03-17T22:51:37.628Z DEBUG   lightningd: Got depth change 64->65 for <txid>
2025-03-17T22:53:07.796Z DEBUG   lightningd: Got depth change 65->66 for <txid>
2025-03-17T22:57:08.062Z DEBUG   lightningd: Got depth change 66->67 for <txid>
2025-03-17T23:24:08.910Z DEBUG   lightningd: Got depth change 67->68 for <txid>
2025-03-17T23:33:39.411Z DEBUG   lightningd: Got depth change 68->69 for <txid>
2025-03-17T23:44:05.580Z UNUSUAL <node id>-chan#14608: Peer permanent failure in ONCHAIN: Funding transaction spent: onchain txid <txid>
2025-03-17T23:44:05.580Z UNUSUAL <node id>-chan#14608: Not dropping our unilateral close onchain since we already saw <txid> confirm.
2025-03-17T23:44:05.688Z DEBUG   <node id>-onchaind-chan#14608: Resolved FUNDING_TRANSACTION/FUNDING_OUTPUT by MUTUAL_CLOSE (txid)
2025-03-18T00:13:41.776Z DEBUG   lightningd: Got first depth change 0->70 for <txid>
2025-03-18T00:27:42.356Z DEBUG   lightningd: Got depth change 70->71 for <txid>
2025-03-18T00:40:12.923Z DEBUG   lightningd: Got depth change 71->72 for <txid>
2025-03-18T00:43:43.298Z DEBUG   lightningd: Got depth change 72->73 for <txid>
2025-03-18T00:53:13.781Z DEBUG   lightningd: Got depth change 73->74 for <txid>
2025-03-18T00:59:44.229Z DEBUG   lightningd: Got depth change 74->75 for <txid>
2025-03-18T01:12:44.743Z DEBUG   lightningd: Got depth change 75->76 for <txid>
2025-03-18T01:27:45.399Z DEBUG   lightningd: Got depth change 76->77 for <txid>
2025-03-18T01:46:46.059Z DEBUG   lightningd: Got depth change 77->78 for <txid>
2025-03-18T01:56:46.540Z DEBUG   lightningd: Got depth change 78->79 for <txid>
2025-03-18T02:01:46.840Z DEBUG   lightningd: Got depth change 79->80 for <txid>
2025-03-18T02:08:17.169Z DEBUG   lightningd: Got depth change 80->81 for <txid>
2025-03-18T02:12:17.418Z DEBUG   lightningd: Got depth change 81->82 for <txid>
2025-03-18T02:18:17.764Z DEBUG   lightningd: Got depth change 82->83 for <txid>
2025-03-18T02:35:48.882Z DEBUG   lightningd: Got depth change 83->84 for <txid>
2025-03-18T02:40:37.108Z UNUSUAL <node id>-chan#14608: Peer permanent failure in ONCHAIN: Funding transaction spent: onchain txid <txid> (reason=unknown)
2025-03-18T02:40:37.108Z UNUSUAL <node id>-chan#14608: Not dropping our unilateral close onchain since we already saw <txid> confirm.
2025-03-18T02:40:37.276Z DEBUG   <node id>-onchaind-chan#14608: Resolved FUNDING_TRANSACTION/FUNDING_OUTPUT by MUTUAL_CLOSE (<txid>)
2025-03-18T02:47:43.060Z DEBUG   lightningd: Got first depth change 0->85 for <txid>
2025-03-18T02:50:13.293Z DEBUG   lightningd: Got depth change 85->86 for <txid>
2025-03-18T02:58:13.693Z DEBUG   lightningd: Got depth change 86->87 for <txid>
2025-03-18T03:09:14.234Z DEBUG   lightningd: Got depth change 87->88 for <txid>
2025-03-18T03:15:14.593Z DEBUG   lightningd: Got depth change 88->89 for <txid>
2025-03-18T03:17:44.856Z DEBUG   lightningd: Got depth change 89->90 for <txid>
2025-03-18T03:21:45.150Z DEBUG   lightningd: Got depth change 90->91 for <txid>
2025-03-18T03:24:45.536Z DEBUG   lightningd: Got depth change 91->93 for <txid>
2025-03-18T03:25:15.711Z DEBUG   lightningd: Got depth change 93->94 for <txid>
2025-03-18T03:28:15.984Z DEBUG   lightningd: Got depth change 94->95 for <txid>
2025-03-18T03:36:46.402Z DEBUG   lightningd: Got depth change 95->96 for <txid>
2025-03-18T03:42:46.755Z DEBUG   lightningd: Got depth change 96->97 for <txid>
2025-03-18T04:10:17.716Z DEBUG   lightningd: Got depth change 97->98 for <txid>
2025-03-18T04:23:18.302Z DEBUG   lightningd: Got depth change 98->99 for <txid>
2025-03-18T04:33:48.748Z DEBUG   lightningd: Got depth change 99->100 for <txid>
@grubles
Copy link
Contributor Author

grubles commented Mar 18, 2025

Maybe related but I've noticed all of the other outputs shown in listfunds are P2TR, but this missing output is P2WPKH.

@grubles
Copy link
Contributor Author

grubles commented Mar 19, 2025

The address for the missing P2WPKH output does not show up in listaddresses but does in dev-listaddrs.

@grubles
Copy link
Contributor Author

grubles commented Mar 19, 2025 •
edited
Loading

Per this comment in #6971 I tried rescanning with the node offline and then doing a dev-rescan-outputs but this had no effect on the funds showing up in listfunds.

@ShahanaFarooqui ShahanaFarooqui added this to the v25.05 milestone Mar 21, 2025
@rustyrussell rustyrussell mentioned this issue Mar 24, 2025
Merged
@grubles grubles mentioned this issue Mar 27, 2025
Closed
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Mar 31, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
066e7d6 
This can happen with 24.11 and later.  We scan back to start of

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Mar 31, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
9f987d1 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Mar 31, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
9925855 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Mar 31, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
fdc586c 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Mar 31, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
cef1e57 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 1, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
d00e200 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 2, 2025
@rustyrussell
lightningd: rescan for missing p2wkph for closed channels.
13a32be 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: ElementsProject#8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
endothermicdev pushed a commit that referenced this issue Apr 4, 2025
@rustyrussell @endothermicdev
lightningd: rescan for missing p2wkph for closed channels.
07669a0 
This can happen with 24.11 and later.  We scan back to exposed channel
opens, or that release.

The BROKEN log messages cause some tests to fail, so we fix those.

Fixes: #8169
Changelog-Fixed: wallet: rescan for missing close outputs (can happen if peer doesn't support option_shutdown_anysegwit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
bug
Projects
None yet
Milestone
v25.05
Development

Successfully merging a pull request may close this issue.

Fix missing p2wpkh for mutual close with old peers. rustyrussell/lightning
3 participants
@rustyrussell @grubles @ShahanaFarooqui